[1.7.x] Add skipVersionTest flag when doing Koji path mask repair#1210
Merged
jdcasey merged 1 commit intoCommonjava:indy-1.7.xfrom Apr 11, 2019
Merged
Conversation
ruhan1
changed the title
ligangty
reviewed
Apr 11, 2019
Contributor
ligangty
left a comment
ligangty
left a comment
There was a problem hiding this comment.
After double check, I'm not sure if remove this version check in repair is correct. For current production config, only redhat-$num styled path can be added as the path mask patterns now in koji proxy. If we remove this check, means will use default paths from brew as paths. So I'm waiting @pkocandr's confirmation to ensure this.
Contributor
Author
|
@ligangty For new repo, we still use the pattern check. This is skipped when repairing. btw, I don't think to do a pattern test against "redhat" is critical. Let's see what others have to say. |
pkocandr
approved these changes
Apr 11, 2019
Contributor
pkocandr
left a comment
pkocandr
left a comment
There was a problem hiding this comment.
I would probably drop the check completely but I'm not sure if it makes sense to ever check the version patterns or not. The intention here was to not proxy anything that don't match the version pattern and filter the contents to only matching artifact, but the result is the right opposite - there are no patterns in the list so the contents are not filtered at all. If this was not based on an existing issue - a brew repo containing artifacts with both redhat version and non-redhat one - then it's ok to switch it off.
Contributor
Author
jdcasey
approved these changes
Apr 11, 2019
ruhan1
added a commit
that referenced
this pull request
Apr 22, 2019
* Remove exception stacktrace for remote url Malformed exception I really don't think this exception stack trace is needed as all useful info has been logged, And it occupied bunch of the log space and polluted the log reading. So removed it. * Use same package type for promotion tmp remote repo * Add separator between name and timestamp in promotion tmp remote repo name * Fix issue for temporary remote not deleted after promotion validation * Add system level gauges for metrics * Avoid any exception break metrics reporting in SystemGaugeSet * Add path promotion files count metrics * Fix license headers * Align SNAPSHOT versions * Disable docker for release for now * [maven-release-plugin] prepare release indy-parent-1.7.4 * [maven-release-plugin] prepare for next development iteration * Remove koji ftests dep and align SNAPSHOT * Update weft to 1.14 * [maven-release-plugin] prepare release indy-parent-1.7.5 * [maven-release-plugin] prepare for next development iteration * Add metrics to monitor store disk usage * Use MetricSetProvider for SystemGaugeSet to enable CDI * Use storage directory directly for monitoring * Use storage path in indy configuration instead for storage metrics * Fix test failure * Support jdbc store for folo-sealed ISPN cache * Fix TrackingKey mapper for WrappedByteArray type Add WrappedByteArray type check in TrackingKey2StringMapper which refers ISPN DefaultTwoWayKey2StringMapper implementation. And also adjust some ISPN config for default settings. * Fix way of WrappedByteArray for TrackingKey by using ObjInputStream * Use externalize but not direct obj stream of TrackingKey2StringMapper * Extract abstract class for key2StringMapper with WrappedArrayByte handling * Allow workflow like promotion to bypass readonly flag * Add configurable envars under mdc logging (#1183) (#1194) * Add configurable envars under mdc logging * ADD static SYSTEM_ OPENSHIFT ENV * EnvironmentConfig refactor, make it focusing on variable keys extracting, add MDC entry by JsonLayout extender * fixing serialization / deserialization in tracking record entries (#1195) * Catch all exceptions in promotion executeValidationRule (#1201) * Fix typo of Storertifact.copyBase() * [1.7.x] Refactor CustomJsonLayout, and test it locally (#1200) * Refactor CustomJsonLayout to use default logback layout configuration for envars This will skip the period when CDI isn't started, when it's still trying to log things. It also skips the need for CDI.current() to lookup the environment configuration, putting the envar extraction config directly in logback.xml Conflicts: deployments/launcher/src/main/etc/indy/logging/logback.xml * Remove old CustomJsonLayout class * remove unused constant * Be more careful about empty strings when pulling envars * adjust example kafka config to include SSL params * Generate metadata for a group containing Maven plugins artifacts (#1207) * [1.7.x] Indy promote perf (#1205) * Performance fixes for promotion * Throw timeout exception in runParallelAndWait * Revert default promotion groovy to use paralleledEach * Add skipVersionTest flag when doing Koji path mask repair (#1210) * [1.7.x] Support paralleledInBatch in promotion tool (#1209) * Support paralleledInBatch in promotion tool * Move batchsize to config and fix commented issues * Update license header * [maven-release-plugin] prepare release indy-parent-1.7.6 * [maven-release-plugin] prepare for next development iteration * put tracking id into the MDC (#1214) * [1.7.x] Fix baseUrl (#1217) * Add MDC entries to mark progress in content promotion (#1216) * Add MDC entries to mark progress in content promotion * fix iteration depth MDC injection clear validation tool iteration MDC items,and give a warning when iteration depth is > 0 * [1.7.x] Promotion error consistency and improved by-path lock scoping (#1219) * Make error reporting consistent for promotion results Set a top-level error if validation fails, and add a succeeded() method too. Also, pull the error/validation handling up into the abstract class, and set a constructor so we can call super() * lock the target repo for paths promotion such that validation is included in scope * fix two tests broken by error/succeeded changes in promotion result classes * stop using ThreadContext for parallel iteration depth counting (#1221) * Remove nested paralleledEach from default promotion groovy (#1222) * Fix byPath promotion gauges (#1225) * Add MDC entries to mark progress in content promotion (#1216) * Add MDC entries to mark progress in content promotion * fix iteration depth MDC injection clear validation tool iteration MDC items,and give a warning when iteration depth is > 0 * [1.7.x] Promotion error consistency and improved by-path lock scoping (#1219) * Make error reporting consistent for promotion results Set a top-level error if validation fails, and add a succeeded() method too. Also, pull the error/validation handling up into the abstract class, and set a constructor so we can call super() * lock the target repo for paths promotion such that validation is included in scope * fix two tests broken by error/succeeded changes in promotion result classes * stop using ThreadContext for parallel iteration depth counting (#1221) * Fix license headers * Use storage path in indy configuration instead for storage metrics * Update license header * Remove exception stacktrace for remote url Malformed exception I really don't think this exception stack trace is needed as all useful info has been logged, And it occupied bunch of the log space and polluted the log reading. So removed it. * Fix test failure * Update license header * Allow workflow like promotion to bypass readonly flag
jdcasey
pushed a commit
to jdcasey/indy
that referenced
this pull request
May 7, 2019
* Remove exception stacktrace for remote url Malformed exception I really don't think this exception stack trace is needed as all useful info has been logged, And it occupied bunch of the log space and polluted the log reading. So removed it. * Use same package type for promotion tmp remote repo * Add separator between name and timestamp in promotion tmp remote repo name * Fix issue for temporary remote not deleted after promotion validation * Add system level gauges for metrics * Avoid any exception break metrics reporting in SystemGaugeSet * Add path promotion files count metrics * Fix license headers * Align SNAPSHOT versions * Disable docker for release for now * [maven-release-plugin] prepare release indy-parent-1.7.4 * [maven-release-plugin] prepare for next development iteration * Remove koji ftests dep and align SNAPSHOT * Update weft to 1.14 * [maven-release-plugin] prepare release indy-parent-1.7.5 * [maven-release-plugin] prepare for next development iteration * Add metrics to monitor store disk usage * Use MetricSetProvider for SystemGaugeSet to enable CDI * Use storage directory directly for monitoring * Use storage path in indy configuration instead for storage metrics * Fix test failure * Support jdbc store for folo-sealed ISPN cache * Fix TrackingKey mapper for WrappedByteArray type Add WrappedByteArray type check in TrackingKey2StringMapper which refers ISPN DefaultTwoWayKey2StringMapper implementation. And also adjust some ISPN config for default settings. * Fix way of WrappedByteArray for TrackingKey by using ObjInputStream * Use externalize but not direct obj stream of TrackingKey2StringMapper * Extract abstract class for key2StringMapper with WrappedArrayByte handling * Allow workflow like promotion to bypass readonly flag * Add configurable envars under mdc logging (Commonjava#1183) (Commonjava#1194) * Add configurable envars under mdc logging * ADD static SYSTEM_ OPENSHIFT ENV * EnvironmentConfig refactor, make it focusing on variable keys extracting, add MDC entry by JsonLayout extender * fixing serialization / deserialization in tracking record entries (Commonjava#1195) * Catch all exceptions in promotion executeValidationRule (Commonjava#1201) * Fix typo of Storertifact.copyBase() * [1.7.x] Refactor CustomJsonLayout, and test it locally (Commonjava#1200) * Refactor CustomJsonLayout to use default logback layout configuration for envars This will skip the period when CDI isn't started, when it's still trying to log things. It also skips the need for CDI.current() to lookup the environment configuration, putting the envar extraction config directly in logback.xml Conflicts: deployments/launcher/src/main/etc/indy/logging/logback.xml * Remove old CustomJsonLayout class * remove unused constant * Be more careful about empty strings when pulling envars * adjust example kafka config to include SSL params * Generate metadata for a group containing Maven plugins artifacts (Commonjava#1207) * [1.7.x] Indy promote perf (Commonjava#1205) * Performance fixes for promotion * Throw timeout exception in runParallelAndWait * Revert default promotion groovy to use paralleledEach * Add skipVersionTest flag when doing Koji path mask repair (Commonjava#1210) * [1.7.x] Support paralleledInBatch in promotion tool (Commonjava#1209) * Support paralleledInBatch in promotion tool * Move batchsize to config and fix commented issues * Update license header * [maven-release-plugin] prepare release indy-parent-1.7.6 * [maven-release-plugin] prepare for next development iteration * put tracking id into the MDC (Commonjava#1214) * [1.7.x] Fix baseUrl (Commonjava#1217) * Add MDC entries to mark progress in content promotion (Commonjava#1216) * Add MDC entries to mark progress in content promotion * fix iteration depth MDC injection clear validation tool iteration MDC items,and give a warning when iteration depth is > 0 * [1.7.x] Promotion error consistency and improved by-path lock scoping (Commonjava#1219) * Make error reporting consistent for promotion results Set a top-level error if validation fails, and add a succeeded() method too. Also, pull the error/validation handling up into the abstract class, and set a constructor so we can call super() * lock the target repo for paths promotion such that validation is included in scope * fix two tests broken by error/succeeded changes in promotion result classes * stop using ThreadContext for parallel iteration depth counting (Commonjava#1221) * Remove nested paralleledEach from default promotion groovy (Commonjava#1222) * Fix byPath promotion gauges (Commonjava#1225) * Add MDC entries to mark progress in content promotion (Commonjava#1216) * Add MDC entries to mark progress in content promotion * fix iteration depth MDC injection clear validation tool iteration MDC items,and give a warning when iteration depth is > 0 * [1.7.x] Promotion error consistency and improved by-path lock scoping (Commonjava#1219) * Make error reporting consistent for promotion results Set a top-level error if validation fails, and add a succeeded() method too. Also, pull the error/validation handling up into the abstract class, and set a constructor so we can call super() * lock the target repo for paths promotion such that validation is included in scope * fix two tests broken by error/succeeded changes in promotion result classes * stop using ThreadContext for parallel iteration depth counting (Commonjava#1221) * Fix license headers * Use storage path in indy configuration instead for storage metrics * Update license header * Remove exception stacktrace for remote url Malformed exception I really don't think this exception stack trace is needed as all useful info has been logged, And it occupied bunch of the log space and polluted the log reading. So removed it. * Fix test failure * Update license header * Allow workflow like promotion to bypass readonly flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for NOSSUP-45 where we want to repair the koji repo's path mask but blocked by the pattern test. After applying this fix, we can do the repair again.