Use the name of the StoreType to do hashcode#2009
Merged
sswguo merged 1 commit intoCommonjava:2.6.xfrom Dec 28, 2021
Merged
Conversation
ruhan1
approved these changes
Dec 28, 2021
Contributor
ruhan1
left a comment
There was a problem hiding this comment.
type is enum. its hashcode should be the object id. this id won't change in the lifetime of a jvm. but type.name is a better idea.
Contributor
Author
It looks it uses the hashcode of Object, but it should not change in the same JVM, I will have a test with this. thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following logs are from stage, which shows two transfers with the same uri and path but different hashcode, that causes the duplicated download jobs for the same transfer, let's use the name of StoreType to do hashcode instead.