Skip to content

Conversation

@sswguo
Copy link
Member

@sswguo sswguo commented May 25, 2022

Fix for MMENG-2881, indy tracks the npm metadata with suffix package.json, which is wrong. I checked and found it just happens when client requests the metadata from group repo, the PR is to keep the origin path in EventMetadata and set it during tracking.

@sswguo sswguo requested review from ligangty, pkocandr and ruhan1 May 25, 2022 03:06
Copy link
Contributor

@ruhan1 ruhan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ligangty ligangty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems only the GET method is covered. Should we also check the HEAD and PUT methods?
And another little nitpick: seems all the REST doc description(@apioperation) is confused, maybe we should consider to give some better docs.

@sswguo
Copy link
Member Author

sswguo commented May 25, 2022

Seems only the GET method is covered. Should we also check the HEAD and PUT methods?

We don't track HEAD in folo, so it's ok to ignore the HEAD, for PUT, we can ask @pkocandr to confirm if this is the same case with GET.

And another little nitpick: seems all the REST doc description(@apioperation) is confused, maybe we should consider to give some better docs.

Yeah, seem so. : ) Will tweak them in another PR.

@sswguo
Copy link
Member Author

sswguo commented May 30, 2022

Checked the folo records of the build mentioned in the jira, there is no such issue for PUT request, I will merge this and do test on devel. thanks.

@sswguo sswguo merged commit ee216ed into Commonjava:2.7.x May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants