fix: stop logging YouTube API keys#133
Open
salvageop wants to merge 1 commit into
Open
Conversation
Fast indexing logged the raw API key at debug level on every YouTube API call. Production defaults to LOG_LEVEL=debug and the log file is downloadable from the settings UI (and commonly pasted into bug reports), so keys leaked into persistent, shareable artifacts. Log the key's rotation position instead.
|
🐳 Image for commit d29b2c5 published: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
YoutubeApi.next_api_key/0logged the raw API key at debug level on every fast-indexing API call:Why it matters
LOG_LEVEL=debug(config/runtime.exs), so this isn't just a dev-mode leakFix
Log the key's rotation position (
Using YouTube API key #1 of 2) instead of the key itself — keeps the round-robin behavior observable without the secret. Added a regression test that captures debug logs and refutes the key appears (fails against the previous code).Testing
tooling/lint_test.shgreen