Fix NuGet restore loop with CPM for SqlDatabaseProjects#1291
Merged
aaronpowell merged 5 commits intoMay 18, 2026
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1291Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1291" |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a NuGet restore loop/circular dependency affecting CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects when consumers use Central Package Management (Directory.Packages.props) by marking build-injected PackageReferences as implicitly defined.
Changes:
- Add
IsImplicitlyDefined="true"toMicrosoft.Build*package references injected via the integration’s.propsfile to prevent CPM from treating them as explicit references.
Contributor
|
LGTM - looking foward to @jmezach 's comments |
jmezach
approved these changes
Apr 23, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ErikEJ
approved these changes
May 18, 2026
Contributor
|
@aaronpowell Privateassets true is not a valid value |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1065
Fixes a NuGet restore loop / circular dependency when using Central Package Management (
Directory.Packages.props) withCommunityToolkit.Aspire.Hosting.SqlDatabaseProjects.This updates the props file in
CommunityToolkit.Aspire.Hosting.SqlDatabaseProjectsto mark the PackageReferences as implicitly defined (IsImplicitlyDefined="true"), preventing CPM from treating them as explicit references and thrashing during restore.Fixes #1065
PR Checklist
Other information
Discussion on the IsImplicitlyDefined property and its relationship with CPM NuGet/Home#13529