feat: add SeaweedFS hosting and client integrations#1349
Open
Stertz wants to merge 3 commits into
Open
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1349Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1349" |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| filerGroup.MapPost("/upload", async ([FromQuery] string fileName, [FromBody] string content, SeaweedFSFilerClient filerClient) => | ||
| { | ||
| var stringContent = new StringContent(content); |
aaronpowell
requested changes
May 26, 2026
Member
aaronpowell
left a comment
aaronpowell
left a comment
There was a problem hiding this comment.
Couple of nits on the namespaces and project files
Comment on lines
+3
to
+7
| <PropertyGroup> | ||
| <TargetFramework>net10.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
| </PropertyGroup> |
Member
There was a problem hiding this comment.
Suggested change
| <PropertyGroup> | |
| <TargetFramework>net10.0</TargetFramework> | |
| <ImplicitUsings>enable</ImplicitUsings> | |
| <Nullable>enable</Nullable> | |
| </PropertyGroup> |
Not needed, we configure those with props files.
Comment on lines
+4
to
+6
| <TargetFramework>net10.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> |
Member
There was a problem hiding this comment.
Suggested change
| <TargetFramework>net10.0</TargetFramework> | |
| <ImplicitUsings>enable</ImplicitUsings> | |
| <Nullable>enable</Nullable> |
Comment on lines
+6
to
+7
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> |
Member
There was a problem hiding this comment.
Suggested change
| <ImplicitUsings>enable</ImplicitUsings> | |
| <Nullable>enable</Nullable> |
| using Microsoft.Extensions.DependencyInjection; | ||
| using Microsoft.Extensions.Diagnostics.HealthChecks; | ||
|
|
||
| #pragma warning disable ASPIREATS001 |
Member
There was a problem hiding this comment.
Let's not throw in global disabling of warnings, put them at the site required so things don't slip through.
|
|
||
| #pragma warning disable ASPIREATS001 | ||
|
|
||
| namespace CommunityToolkit.Aspire.Hosting.SeaweedFS; |
Member
There was a problem hiding this comment.
Suggested change
| namespace CommunityToolkit.Aspire.Hosting.SeaweedFS; | |
| namespace Aspire.Hosting; |
I think that's all we want it to be - double check other integrations
| using System.Threading.Tasks; | ||
| using Aspire.Hosting.ApplicationModel; | ||
|
|
||
| namespace CommunityToolkit.Aspire.Hosting.SeaweedFS; |
Member
There was a problem hiding this comment.
Suggested change
| namespace CommunityToolkit.Aspire.Hosting.SeaweedFS; | |
| namespace Aspire.Hosting; |
I think that's all we want it to be - double check other integrations
Comment on lines
+6
to
+7
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> |
Member
There was a problem hiding this comment.
Suggested change
| <ImplicitUsings>enable</ImplicitUsings> | |
| <Nullable>enable</Nullable> |
| using Microsoft.Extensions.Diagnostics.HealthChecks; | ||
| using Microsoft.Extensions.Hosting; | ||
|
|
||
| namespace CommunityToolkit.Aspire.SeaweedFS.Client; |
Member
There was a problem hiding this comment.
Suggested change
| namespace CommunityToolkit.Aspire.SeaweedFS.Client; | |
| namespace Microsoft.Extensions.Hosting; |
I think that's all we want it to be - double check other integrations
| using System.Data.Common; | ||
| using Amazon.S3; | ||
|
|
||
| namespace CommunityToolkit.Aspire.SeaweedFS.Client; |
Member
There was a problem hiding this comment.
Suggested change
| namespace CommunityToolkit.Aspire.SeaweedFS.Client; | |
| namespace Microsoft.Extensions.Hosting; |
I think that's all we want it to be - double check other integrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1336
Overview of changes
This PR introduces the SeaweedFS integration for the Aspire Community Toolkit, providing a highly performant and scalable object/file storage alternative.
As discussed in the linked issue, it includes:
CommunityToolkit.Aspire.Hosting.SeaweedFS): A robust AppHost resource builder that configures the SeaweedFS cluster, exposing both the S3 Gateway and the Native Filer endpoints dynamically, along with data volume persistence support.CommunityToolkit.Aspire.SeaweedFS.Client): Extensions to seamlessly inject the standardAWSSDK.S3client and a strongly-typedSeaweedFSFilerClientusing Aspire's service discovery, complete with independent health checks.All details and motivations are outlined in the linked issue.
PR Checklist