-
Notifications
You must be signed in to change notification settings - Fork 142
[WIP] Implement Zitadel IDP #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Implement Zitadel IDP #549
Conversation
|
This PR contains a couple missing features currently:
I had these in my original code, but it seems to have been lost to time so I've needed to recreate it from scratch. |
src/CommunityToolkit.Aspire.Hosting.Zitadel/ZitadelResourceBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
| /// <summary> | ||
| /// latest | ||
| /// </summary> | ||
| public const string Tag = "latest"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it ship specific version numbers? If so, can we pin it so that we ensure consistent behaviour over time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears they have a mix of actual version numbers and generated ids. The generated ids appear to be builds for specific PRs/branches so I think we can ignore those.
How should we handle pinning these? Are you thinking a static class with const strings or an enum? Or do you mean just ship it with an explicit version as the tag rather than latest?
Edit: Here is the current latest version (not counting the hash value tags) https://github.com/zitadel/zitadel/pkgs/container/zitadel/376730503?tag=v2.66.14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should align with the release that is published as latest - https://github.com/zitadel/zitadel/releases
Currently, that is v2.71.4
Closes #350
This PR implements an Aspire integration to add support for the Zitadel IDP (https://zitadel.com).
PR Checklist
Other information