Skip to content

Conversation

@TheBrambleShark
Copy link

Closes #350

This PR implements an Aspire integration to add support for the Zitadel IDP (https://zitadel.com).

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

@TheBrambleShark TheBrambleShark marked this pull request as draft March 8, 2025 20:23
@TheBrambleShark
Copy link
Author

This PR contains a couple missing features currently:

  • Docs have yet to be written
  • Tests have yet to be written
  • There is no integration with a CockroachDB or PostgreSQL database for Zitadel to store data.
  • Health check has not yet been implemented.

I had these in my original code, but it seems to have been lost to time so I've needed to recreate it from scratch.

@github-actions github-actions bot added the Stale label Mar 14, 2025
@aaronpowell aaronpowell added awaiting response Waiting for the author of the issue to provide more information or answer a question and removed Stale labels Mar 15, 2025
/// <summary>
/// latest
/// </summary>
public const string Tag = "latest";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it ship specific version numbers? If so, can we pin it so that we ensure consistent behaviour over time.

Copy link
Author

@TheBrambleShark TheBrambleShark Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears they have a mix of actual version numbers and generated ids. The generated ids appear to be builds for specific PRs/branches so I think we can ignore those.

How should we handle pinning these? Are you thinking a static class with const strings or an enum? Or do you mean just ship it with an explicit version as the tag rather than latest?

Edit: Here is the current latest version (not counting the hash value tags) https://github.com/zitadel/zitadel/pkgs/container/zitadel/376730503?tag=v2.66.14

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should align with the release that is published as latest - https://github.com/zitadel/zitadel/releases

Currently, that is v2.71.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting response Waiting for the author of the issue to provide more information or answer a question Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Component - Add custom Zitadel IDP component to aspire

3 participants