Skip to content

Conversation

@vgromfeld
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

When clicking on the sign out hyperlink in the authenticated user flyout, the flyout remains visible without any information until the sign out is complete:

image

During this phase, the hyperlink remains clickable but is not doing anything.

What is the new behavior?

The authenticated user flyout will now be dismissed immediately when clicking on the sign out hyperlink.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@ghost
Copy link

ghost commented Mar 2, 2020

Thanks vgromfeld for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@ghost ghost assigned michael-hawker Mar 2, 2020
@michael-hawker michael-hawker merged commit 712f97e into CommunityToolkit:master Jun 12, 2020
@vgromfeld vgromfeld deleted the hideFlyoutOnClick branch June 15, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants