Skip to content

Niels9001/New icon assets#202

Merged
michael-hawker merged 9 commits intomainfrom
niels9001/iconupdates
Jul 19, 2022
Merged

Niels9001/New icon assets#202
michael-hawker merged 9 commits intomainfrom
niels9001/iconupdates

Conversation

@niels9001
Copy link
Copy Markdown
Contributor

Adding all necessary icon assets for all scales using the correct corner radii, shadows and grid defined by the design guidelines.

Start
image

Search
image

App list
image

Taskbar
image

In app titlebar
image

Splashscreen
image

@niels9001 niels9001 requested a review from michael-hawker July 18, 2022 14:06
Comment on lines +39 to +44
<uap:DefaultTile Wide310x150Logo="Assets\Wide310x150Logo.png" Square71x71Logo="Assets\SmallTile.png" Square310x310Logo="Assets\LargeTile.png">
<uap:ShowNameOnTiles>
<uap:ShowOn Tile="square150x150Logo"/>
<uap:ShowOn Tile="square310x310Logo"/>
</uap:ShowNameOnTiles>
</uap:DefaultTile >
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update the manifest in the project templates/experiments as well?

@michael-hawker
Copy link
Copy Markdown
Member

Looks like there's some issues in the CI:

"D:\a\Labs-Windows\Labs-Windows\Toolkit.Labs.All.sln" (default target) (1:2) ->
"D:\a\Labs-Windows\Labs-Windows\platforms\CommunityToolkit.Labs.Skia.Gtk\CommunityToolkit.Labs.Skia.Gtk.csproj" (default target) (9:6) ->
(_CopyOutOfDateSourceItemsToOutputDirectoryAlways target) -> 
  C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Current\Bin\Microsoft.Common.CurrentVersion.targets(5128,5): error MSB3030: Could not copy the file "D:\a\Labs-Windows\Labs-Windows\common\CommunityToolkit.Labs.Shared\Assets\StoreLogo.png" because it was not found. [D:\a\Labs-Windows\Labs-Windows\platforms\CommunityToolkit.Labs.Skia.Gtk\CommunityToolkit.Labs.Skia.Gtk.csproj]
"D:\a\Labs-Windows\Labs-Windows\Toolkit.Labs.All.sln" (default target) (1:2) ->
"D:\a\Labs-Windows\Labs-Windows\tests\CommunityToolkit.Labs.Tests.Uwp\CommunityToolkit.Labs.Tests.Uwp.csproj" (default target) (14:6) ->
(PrepareILCInputFolder target) -> 
  C:\Users\runneradmin\.nuget\packages\microsoft.net.native.compiler\2.2.10-rel-29722-00\tools\Microsoft.NetNative.targets(589,5): error MSB3030: Could not copy the file "D:\a\Labs-Windows\Labs-Windows\common\CommunityToolkit.Labs.Shared\Assets\StoreLogo.png" because it was not found. [D:\a\Labs-Windows\Labs-Windows\tests\CommunityToolkit.Labs.Tests.Uwp\CommunityToolkit.Labs.Tests.Uwp.csproj]
"D:\a\Labs-Windows\Labs-Windows\Toolkit.Labs.All.sln" (default target) (1:2) ->
"D:\a\Labs-Windows\Labs-Windows\tests\CommunityToolkit.Labs.Tests.WinAppSdk\CommunityToolkit.Labs.Tests.WinAppSdk.csproj" (default target) (15:6) ->
(_GenerateAppxPackageRecipeFile target) -> 
  C:\Users\runneradmin\.nuget\packages\microsoft.windowsappsdk\1.0.3\buildTransitive\Microsoft.Build.Msix.Packaging.targets(1497,5): error APPX0702: Payload file 'D:\a\Labs-Windows\Labs-Windows\common\CommunityToolkit.Labs.Shared\Assets\LockScreenLogo.png' does not exist. [D:\a\Labs-Windows\Labs-Windows\tests\CommunityToolkit.Labs.Tests.WinAppSdk\CommunityToolkit.Labs.Tests.WinAppSdk.csproj]
  C:\Users\runneradmin\.nuget\packages\microsoft.windowsappsdk\1.0.3\buildTransitive\Microsoft.Build.Msix.Packaging.targets(1497,5): error APPX0702: Payload file 'D:\a\Labs-Windows\Labs-Windows\common\CommunityToolkit.Labs.Shared\Assets\SplashScreen.png' does not exist. [D:\a\Labs-Windows\Labs-Windows\tests\CommunityToolkit.Labs.Tests.WinAppSdk\CommunityToolkit.Labs.Tests.WinAppSdk.csproj]
  C:\Users\runneradmin\.nuget\packages\microsoft.windowsappsdk\1.0.3\buildTransitive\Microsoft.Build.Msix.Packaging.targets(1497,5): error APPX0702: Payload file 'D:\a\Labs-Windows\Labs-Windows\common\CommunityToolkit.Labs.Shared\Assets\Square150x150Logo.png' does not exist. [D:\a\Labs-Windows\Labs-Windows\tests\CommunityToolkit.Labs.Tests.WinAppSdk\CommunityToolkit.Labs.Tests.WinAppSdk.csproj]
  C:\Users\runneradmin\.nuget\packages\microsoft.windowsappsdk\1.0.3\buildTransitive\Microsoft.Build.Msix.Packaging.targets(1497,5): error APPX0702: Payload file 'D:\a\Labs-Windows\Labs-Windows\common\CommunityToolkit.Labs.Shared\Assets\Square44x44Logo.png' does not exist. [D:\a\Labs-Windows\Labs-Windows\tests\CommunityToolkit.Labs.Tests.WinAppSdk\CommunityToolkit.Labs.Tests.WinAppSdk.csproj]
  C:\Users\runneradmin\.nuget\packages\microsoft.windowsappsdk\1.0.3\buildTransitive\Microsoft.Build.Msix.Packaging.targets(1497,5): error APPX0702: Payload file 'D:\a\Labs-Windows\Labs-Windows\common\CommunityToolkit.Labs.Shared\Assets\StoreLogo.png' does not exist. [D:\a\Labs-Windows\Labs-Windows\tests\CommunityToolkit.Labs.Tests.WinAppSdk\CommunityToolkit.Labs.Tests.WinAppSdk.csproj]
  C:\Users\runneradmin\.nuget\packages\microsoft.windowsappsdk\1.0.3\buildTransitive\Microsoft.Build.Msix.Packaging.targets(1497,5): error APPX0702: Payload file 'D:\a\Labs-Windows\Labs-Windows\common\CommunityToolkit.Labs.Shared\Assets\Wide310x150Logo.png' does not exist. [D:\a\Labs-Windows\Labs-Windows\tests\CommunityToolkit.Labs.Tests.WinAppSdk\CommunityToolkit.Labs.Tests.WinAppSdk.csproj]

@michael-hawker
Copy link
Copy Markdown
Member

Ah, I think the package manifest itself still requires the base images if I remember correctly? So maybe we can just leave those versions there for now? It'd be good to lock down the template so we can spawn off different experiments.

@michael-hawker
Copy link
Copy Markdown
Member

So close!

"D:\a\Labs-Windows\Labs-Windows\Toolkit.Labs.All.sln" (default target) (1:2) ->
"D:\a\Labs-Windows\Labs-Windows\tests\CommunityToolkit.Labs.Tests.Uwp\CommunityToolkit.Labs.Tests.Uwp.csproj" (default target) (14:6) ->
(PrepareILCInputFolder target) -> 
  C:\Users\runneradmin\.nuget\packages\microsoft.net.native.compiler\2.2.10-rel-29722-00\tools\Microsoft.NetNative.targets(589,5): error MSB3030: Could not copy the file "D:\a\Labs-Windows\Labs-Windows\common\CommunityToolkit.Labs.Shared\Assets\LockScreenLogo.scale-200.png" because it was not found. [D:\a\Labs-Windows\Labs-Windows\tests\CommunityToolkit.Labs.Tests.Uwp\CommunityToolkit.Labs.Tests.Uwp.csproj]

Copy link
Copy Markdown
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully the last template change for now. CI passed, and codespaces seems good. Will see if run into any other issues as I update other experiments.

@michael-hawker michael-hawker merged commit 806896f into main Jul 19, 2022
@delete-merged-branch delete-merged-branch Bot deleted the niels9001/iconupdates branch July 19, 2022 22:47
Martin1994 pushed a commit to Martin1994/Labs-Windows that referenced this pull request Sep 2, 2023
* New icon assets

* Fix smalltile path

* Path issue fix

* Removing scalefactor

* Updated storelogo paths

* Adding missing files

* Fix image sizes

* Update CommunityToolkit.Labs.Tests.Uwp.csproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants