Skip to content

Bump RiveSharp and SkiaSharp references#328

Merged
Arlodotexe merged 1 commit intoCommunityToolkit:mainfrom
rive-app:net7
Dec 8, 2022
Merged

Bump RiveSharp and SkiaSharp references#328
Arlodotexe merged 1 commit intoCommunityToolkit:mainfrom
rive-app:net7

Conversation

@csmartdalton
Copy link
Copy Markdown
Contributor

@csmartdalton csmartdalton commented Dec 6, 2022

The newer packages have emsdk 3.1.12 builds, which are compatible with Uno.Wasm.Bootstrap 7.x.

Fixes rive-app/rive-sharp#4

@michael-hawker
Copy link
Copy Markdown
Member

Thanks! We can merge this in once the CI passes and @Arlodotexe approves - this should resolve what you need right?

@csmartdalton did we want to finish up #307 as well by moving to the DispatcherQueueTimer and then can bump the package version number?

@csmartdalton
Copy link
Copy Markdown
Contributor Author

Thanks! We can merge this in once the CI passes and @Arlodotexe approves - this should resolve what you need right?

@csmartdalton did we want to finish up #307 as well by moving to the DispatcherQueueTimer and then can bump the package version number?

😱 I totally let that one slip!

Let's get it wrapped up.

The newer packages have emsdk 3.1.12 builds, which are compatible with
Uno.Wasm.Bootstrap 7.x.

Fixes #4
@csmartdalton
Copy link
Copy Markdown
Contributor Author

csmartdalton commented Dec 8, 2022

Looks like the build system tripped on SkiaSharp.Views 2.88.3, but we can land with 2.88.2 for now.

We will still have to get on SkiaSharp 2.88.3 before updating the bootstrapper, but RiveSharp is ready to go.

Copy link
Copy Markdown
Member

@Arlodotexe Arlodotexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what we needed, big thanks @csmartdalton!

@Arlodotexe Arlodotexe merged commit eb04e35 into CommunityToolkit:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not compatible with Uno.Wasm.Bootstrap 7.x

3 participants