Skip to content

Consolidate Solution Files#157

Merged
TheCodeTraveler merged 3 commits intomainfrom
Consolidate-Files
Oct 19, 2021
Merged

Consolidate Solution Files#157
TheCodeTraveler merged 3 commits intomainfrom
Consolidate-Files

Conversation

@TheCodeTraveler
Copy link
Copy Markdown
Collaborator

@TheCodeTraveler TheCodeTraveler commented Oct 18, 2021

Description

Similar PR for CommunityToolkit.Maui.Markup: CommunityToolkit/Maui.Markup#10

This removes duplicate global.json or Directory.Build.props files, preventing a future error where one global.json or Directory.Build.props files may be updated.

Prior to this PR, both CommunityToolkit.Maui.sln and CommunityToolkit.Maui.Sample.sln used separate files for global.json or Directory.Build.props, however, both files contained the sample implementations.

Detailed Solution

  • Move global.json to root folder
  • Move Directory.Build.props to root folder
  • Update file reference paths in CommunityToolkit.Maui.sln
  • Update file reference paths in CommunityToolkit.Maui.Samples.sln
  • Adds dotnet_diagnostic.CS4014.severity = error to .editorconfig

@TheCodeTraveler TheCodeTraveler merged commit 8f0c710 into main Oct 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the Consolidate-Files branch October 19, 2021 22:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant