Added color converters samples#159
Merged
TheCodeTraveler merged 6 commits intoCommunityToolkit:mainfrom Oct 19, 2021
Merged
Conversation
Based on MCT Sample, with some modifications: - Formatted Strings did not work - BoxView at the bottom did not work either - There is a weird warnings on the Constructor
To black and white To Color for text To Grayscale color To inverse color
Member
Probably that's caused by the source generator, maybe they fix it in the next release. For reference: For the other bugs I'll open issues on maui repo (feel free to do it, if you can and want to do) |
TheCodeTraveler
requested changes
Oct 19, 2021
Collaborator
TheCodeTraveler
left a comment
TheCodeTraveler
left a comment
There was a problem hiding this comment.
Thanks @juansturla!
Just a couple things to tweak 👍
Capitalized variables Removed #pragma Changed Dictionary to IReadOnlyDictionary
Contributor
Author
|
Requested changes were solved |
TheCodeTraveler
approved these changes
Oct 19, 2021
Collaborator
|
Approved. Thanks @juansturla! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for a sample for
#52 Color to Colors converter
#53 Color to Color Component Converter
#54 Color to String converter
Based on MCT Sample, with some modifications on the code-behind:
FormattedStringsdid not work with<span>. Changed for aTextwithStringFormatBoxViewat the bottom of the page did not work either, had to move it to the top and set a defaultBackgroundColor ="White"pickerand theboxViewmight not have a value (I supressed the warning)FieldInfo.Valueis null, returnsColors.White