Fix Media Element Popup crash when switching to Full Screen mode#2505
Closed
ne0rrmatrix wants to merge 8 commits intoCommunityToolkit:mainfrom
Closed
Fix Media Element Popup crash when switching to Full Screen mode#2505ne0rrmatrix wants to merge 8 commits intoCommunityToolkit:mainfrom
ne0rrmatrix wants to merge 8 commits intoCommunityToolkit:mainfrom
Conversation
dotnet-policy-service
bot
added
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Remove Close method for Media Element Popup in Sample app. We had a handler disconnect that is no longer required that was crashing the popup. Removing it and allowing Maui to automatically control the handler removal fixes the issue.
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRVideo
Windows:
2025-02-10.04-31-03.mp4
iOS:
2025-02-10.05-54-21.mov