In CommunityToolkit.Maui.Core, Rename Popup to Alert#291
Merged
TheCodeTraveler merged 5 commits intomainfrom Feb 11, 2022
Merged
In CommunityToolkit.Maui.Core, Rename Popup to Alert#291TheCodeTraveler merged 5 commits intomainfrom
CommunityToolkit.Maui.Core, Rename Popup to Alert#291TheCodeTraveler merged 5 commits intomainfrom
Conversation
TheCodeTraveler
changed the title
CommunityToolkit.Maui.Core, Rename Popup to Alert`CommunityToolkit.Maui.Core, Rename Popup to Alert
| @@ -6,28 +6,28 @@ namespace CommunityToolkit.Maui.Core.Views; | |||
| /// <summary> | |||
| /// Popup for iOS + MacCatalyst | |||
Contributor
There was a problem hiding this comment.
Suggested change
| /// Popup for iOS + MacCatalyst | |
| /// Alert for iOS + MacCatalyst |
Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com>
Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com>
Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com>
Collaborator
Author
|
Thanks @VladislavAntonyuk!! I've implemented your feedback and it is ready for one more review! |
pictos
approved these changes
Feb 11, 2022
Member
pictos
left a comment
pictos
left a comment
There was a problem hiding this comment.
LGTM!
Thanks for moving this forward
delete-merged-branch
bot
deleted the
Rename-`CommunityToolkit.Core.Views.Popup`
branch
Contributor
|
just 1 minor leftover: https://github.com/CommunityToolkit/Maui/blob/main/src/CommunityToolkit.Maui.Core/Views/Alert/Alert.macios.cs#L7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
With the introduction of the Popup PR, we introduce a naming conflict between existing files with the name
PopupinCommunityToolkit.Maui.Core.Since
Popup.macios.csandPopupView.macios.csare exclusively used byIAlertcontrols, this PR proposes renames the files:Popup.macios.cs->Alert.macios.csPopupView.macios.cs->AlertView.macios.csLinked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PR