Implement VariableMultiValueConverter Sample#307
Merged
TheCodeTraveler merged 13 commits intoCommunityToolkit:mainfrom Feb 24, 2022
Merged
Implement VariableMultiValueConverter Sample#307TheCodeTraveler merged 13 commits intoCommunityToolkit:mainfrom
TheCodeTraveler merged 13 commits intoCommunityToolkit:mainfrom
Conversation
Add ItemSelectedEventArgsConverterPage Add ItemSelectedEventArgsConverterViewModel Register page and view model with services Add sample to converter gallery
…ple.csproj Co-authored-by: Pedro Jesus <pedrojesus.cefet@gmail.com>
Collaborator
|
Thanks @marsscotia! Could you do me a quick favor and comment on the Proposal so that I can add you as an assignee and remove the |
VladislavAntonyuk
previously approved these changes
Feb 23, 2022
TheCodeTraveler
requested changes
Feb 24, 2022
Collaborator
TheCodeTraveler
left a comment
TheCodeTraveler
left a comment
There was a problem hiding this comment.
Thanks @marsscotia!
Just a small request to use a Grid to replace the nested Stacklayouts 👍
don't attempt to reproduce the appearance of a specific layout by using combinations of other layouts, as this results in unnecessary layout calculations being performed. For example, don't attempt to reproduce a Grid layout by using a combination of StackLayout instances
TheCodeTraveler
approved these changes
Feb 24, 2022
Collaborator
TheCodeTraveler
left a comment
TheCodeTraveler
left a comment
There was a problem hiding this comment.
Thanks @marsscotia!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Implement VariableMultiValueConverter sample.
Add to VariableMultiValueConverterViewModel
Add to VariableMultiValueConverterPage
Register ViewModel in services
As this is purely the implementation of a sample, there is no additional documentation or tests.
Linked Issues
PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information