Add ColorToColor Converter Unit Tests#311
Merged
TheCodeTraveler merged 3 commits intomainfrom Mar 3, 2022
Merged
Conversation
bijington
reviewed
Mar 3, 2022
bijington
previously approved these changes
Mar 3, 2022
Contributor
bijington
left a comment
bijington
left a comment
There was a problem hiding this comment.
I doubt my comment is blocking. In fact it's probably me trying to understand a bit more :)
VladislavAntonyuk
previously approved these changes
Mar 3, 2022
TheCodeTraveler
dismissed stale reviews from VladislavAntonyuk and bijington
via
211ba40
VladislavAntonyuk
approved these changes
Mar 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR implements unit tests for the ColorToColor Converters found in
ColorToColorConverters.shared.csLinked Issues
Color-To-ColorConverters #52PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
I've also added
ArgumentNullException.ThrowIfNull(value);to each Converter. Even though we have<nullable>Enable</nullable>, devs who do not have nullable enabled may still try to pass innullvia the public API.