CameraView fix for Android: video recording and rotation by zhitaop · Pull Request #3168 · CommunityToolkit/Maui

zhitaop · 2026-03-20T09:55:24Z

Description of Change

This PR fixes a bug on Android where attempting to record a video for a second time will fail: CleanupVideoRecordingResources() no longer disposes videoRecorder and videoCapture after each recording session. This prevents the "Null Stream" error caused by trying to record with a disposed object.
Added a CaptureSessionMode enum and session state tracking to distinguish image capture and video capture workflows.
Refactored camera setup into smaller use case rebuild/rebind steps
Image capture workflow no longer binds the videoCapture use case as it might slow down image capture. Only binds videoCapture use case when recording starts.
Improves orientation handling by applying rotation consistently to imageCapture, videoCapture, and cameraPreview.
Updated OnMediaCaptured() in the sample app to avoid file locking issues and improves image display

Linked Issues

PR Checklist

Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
Has tests (if omitted, state reason in description)
Has samples (if omitted, state reason in description)
Rebased on top of main at time of PR
Changes adhere to coding standard
Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

Copilot

Pull request overview

This PR updates the Android CameraManager implementation to improve repeated video recording reliability and to apply device rotation consistently across CameraX use cases (preview, image capture, and video capture).

Changes:

Keeps VideoCapture/Recorder alive across recording sessions by stopping disposal in CleanupVideoRecordingResources().
Rebuilds video recording use cases on-demand in PlatformStartVideoRecording() when they are missing (e.g., after a resolution change).
Centralizes orientation-to-surface-rotation mapping and applies it to imageCapture, videoCapture, and cameraPreview.

src/CommunityToolkit.Maui.Camera/CameraManager.android.cs

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

src/CommunityToolkit.Maui.Camera/CameraManager.android.cs

…ideo capture session

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

src/CommunityToolkit.Maui.Camera/CameraManager.android.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…/github.com/zhitaop/CommunityToolkitMaui into pr/3168

…ingStream`

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Copilot · 2026-04-02T18:43:55Z

src/CommunityToolkit.Maui.Camera/CameraManager.android.cs

+			.SetCaptureMode(imageCaptureMode)
 			.SetResolutionSelector(resolutionSelector)
-			?.Build() ?? throw new InvalidOperationException("Unable to set resolution selector");
+			.Build();


Rebuilding imageCapture here creates a brand-new ImageCapture instance, which will reset any previously applied configuration (e.g., flash mode set via UpdateFlashMode). Consider re-applying the current cameraView.CameraFlashMode (and any other relevant settings) to the new imageCapture immediately after building it, so starting/stopping video recording or session rebinds don’t silently revert user settings.

Suggested change

.Build();

.Build();

if (cameraView is not null)

{

UpdateFlashMode(cameraView.CameraFlashMode);

}

Copilot · 2026-04-02T18:43:55Z

src/CommunityToolkit.Maui.Camera/CameraManager.windows.cs


 		await mediaRecording.StopAsync();
+
+		if(videoCaptureStream.CanSeek)


Code style: add a space after if to match the surrounding formatting (if (videoCaptureStream.CanSeek)).

Suggested change

if(videoCaptureStream.CanSeek)

if (videoCaptureStream.CanSeek)

TheCodeTraveler

Thanks @zhitaop!!

…olkit#3168) * Fix video recording and use case target rotation * Address Copilot review * Refactor building and binding use cases, separate image capture and video capture session * Update CameraViewPage MediaCaptured handler * Refactor `CaptureSessionMode` enum * Update src/CommunityToolkit.Maui.Camera/CameraManager.android.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Set `videoRecordingStream.Position = 0` before returning `videoRecordingStream` * Fix CameraView page on Windows Sample App * Remove the need to update Stream Position in Sample App --------- Co-authored-by: Brandon Minnick <13558917+TheCodeTraveler@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Fix video recording and use case target rotation

4f2cb9e

Copilot AI review requested due to automatic review settings March 20, 2026 09:55

Copilot started reviewing on behalf of zhitaop March 20, 2026 09:55 View session

zhitaop mentioned this pull request Mar 20, 2026

[BUG] CameraView Video Recording issues on iOS and Android #3166

Closed

2 tasks

Merge branch 'main' into fix/camera-videorecord-and-rotation-android

e492f10

zhitaop mentioned this pull request Mar 20, 2026

[BUG] CameraView preview doesn't rotate on certain Android devices #3015

Closed

2 tasks

Copilot AI reviewed Mar 20, 2026

View reviewed changes

src/CommunityToolkit.Maui.Camera/CameraManager.android.cs Show resolved Hide resolved

src/CommunityToolkit.Maui.Camera/CameraManager.android.cs Outdated Show resolved Hide resolved

Address Copilot review

7c3e712

TheCodeTraveler requested a review from Copilot March 20, 2026 15:20

Copilot started reviewing on behalf of TheCodeTraveler March 20, 2026 15:21 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

src/CommunityToolkit.Maui.Camera/CameraManager.android.cs Outdated Show resolved Hide resolved

src/CommunityToolkit.Maui.Camera/CameraManager.android.cs Outdated Show resolved Hide resolved

TheCodeTraveler and others added 5 commits March 20, 2026 11:27

Merge branch 'main' into fix/camera-videorecord-and-rotation-android

033d587

Merge branch 'main' into fix/camera-videorecord-and-rotation-android

e0b24fc

Merge branch 'main' into fix/camera-videorecord-and-rotation-android

0a04a9d

Refactor building and binding use cases, separate image capture and v…

1da5b06

…ideo capture session

Update CameraViewPage MediaCaptured handler

513c117

TheCodeTraveler requested a review from Copilot April 2, 2026 17:58

Copilot started reviewing on behalf of TheCodeTraveler April 2, 2026 17:58 View session

Copilot AI reviewed Apr 2, 2026

View reviewed changes

src/CommunityToolkit.Maui.Camera/CameraManager.android.cs Show resolved Hide resolved

src/CommunityToolkit.Maui.Camera/CameraManager.android.cs Show resolved Hide resolved

src/CommunityToolkit.Maui.Camera/CameraManager.android.cs Outdated Show resolved Hide resolved

TheCodeTraveler and others added 6 commits April 2, 2026 11:04

Refactor CaptureSessionMode enum

346eb9e

Update src/CommunityToolkit.Maui.Camera/CameraManager.android.cs

28d900f

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'main' into pr/3168

07170a7

Merge branch 'fix/camera-videorecord-and-rotation-android' of https:/…

af92646

…/github.com/zhitaop/CommunityToolkitMaui into pr/3168

Set videoRecordingStream.Position = 0 before returning `videoRecord…

8bfb531

…ingStream`

Fix CameraView page on Windows Sample App

d746fe5

TheCodeTraveler requested a review from Copilot April 2, 2026 18:37

Copilot started reviewing on behalf of TheCodeTraveler April 2, 2026 18:37 View session

Remove the need to update Stream Position in Sample App

33a2aa7

Copilot AI reviewed Apr 2, 2026

View reviewed changes

TheCodeTraveler approved these changes Apr 2, 2026

View reviewed changes

TheCodeTraveler merged commit 87e176c into CommunityToolkit:main Apr 2, 2026
10 checks passed

zhitaop deleted the fix/camera-videorecord-and-rotation-android branch April 3, 2026 02:06

github-actions bot locked and limited conversation to collaborators Apr 4, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CameraView fix for Android: video recording and rotation#3168

CameraView fix for Android: video recording and rotation#3168
TheCodeTraveler merged 15 commits intoCommunityToolkit:mainfrom
zhitaop:fix/camera-videorecord-and-rotation-android

zhitaop commented Mar 20, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

TheCodeTraveler left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		await mediaRecording.StopAsync();

		if(videoCaptureStream.CanSeek)

	if(videoCaptureStream.CanSeek)
	if (videoCaptureStream.CanSeek)

Conversation

zhitaop commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Linked Issues

PR Checklist

Additional information

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

TheCodeTraveler left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

zhitaop commented Mar 20, 2026 •

edited

Loading