Refactor the IntToBoolConverter to use the BaseConverter

[bijington]

Description of Change

Refactors the IntToBoolConverter to use the BaseConverter.

Linked Issues

n/a

PR Checklist

• Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
• Has tests (if omitted, state reason in description)
• Has samples (if omitted, state reason in description)
• Rebased on top of main at time of PR
• Changes adhere to coding standard
• Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls/XYZ

Additional information

[TheCodeTraveler]

Adding the blocked tag until #325 is merged

[TheCodeTraveler]

Thanks Shaun!

Could you also fix the Unit Test Method names? It looks like the current method names are leftover from a copy/paste of IndexToArrayConverter's tests:

• IntToBoolConverter_Tests.IndexToArrayConverter -> IntToBoolConverter_Tests.IntToBoolConverter
• IntToBoolConverter_Tests.IndexToArrayConverterBack -> IntToBoolConverter_Tests.IntToBoolConverterBack

[TheCodeTraveler]

Let's swap these Assert.Equal parameters around.

It's kinda trivial, but when the Assert fails, it'll print "...Expected: [first parameter] Actual: [second parameter]" which can be confusing if the parameters are reversed

Suggested change

	Assert.Equal(result, expectedResult);
	Assert.Equal(typedResult, expectedResult);
	Assert.Equal(expectedResult, result);
	Assert.Equal(expectedResult, typedResult);

[TheCodeTraveler]

Let's swap these Assert.Equal parameters around.

It's kinda trivial, but when the Assert fails, it'll print "...Expected: [first parameter] Actual: [second parameter]" which can be confusing if the parameters are reversed.

Suggested change

	Assert.Equal(result, expectedResult);
	Assert.Equal(typedResult, expectedResult);
	Assert.Equal(expectedResult, result);
	Assert.Equal(expectedResult, typedResult);

[TheCodeTraveler]

Let's fix this small typo from a previous PR

Suggested change

	public void InValidConverterValuesThrowArgumentException(object value)
	public void InvalidConverterValuesThrowArgumentException(object value)

[TheCodeTraveler]

Let's fix this small typo from a previous PR

Suggested change

	public void InValidConverterBackValuesThrowArgumentException(object value)
	public void InvalidConverterBackValuesThrowArgumentException(object value)

[bijington]

@brminnick rhanks for the fix. I haven't removed the extensions around asserting the Excoetional conditions. What are your thoughts?

[TheCodeTraveler]

Hey Shaun! I went ahead and pulled out the converter assert extension methods. I think it's best to keep the Unit Tests as simple/dumb as possible to make it easier for us to understand why unit tests are failing when writing future PRs.

For example, when Vincent Hoogendoorn wrote the unit tests for the Markup library, he made them very complex and now it's tough to understand what a Unit Test is doing and, worse, to understand why a Unit Test is failing: https://github.com/CommunityToolkit/Maui.Markup/blob/main/src/CommunityToolkit.Maui.Markup.UnitTests/BindableObjectExtensionsTests.cs

[bijington]

No problem, I get that argument and missed you had removed them. I wanted to make sure before this went in 😃