Update Sample App for .NET MAUI Preview 14#329
Conversation
|
I've opened this as a Draft PR because of the Flyout / Shell problems on iOS + MacCatalyst. @pictos @VladislavAntonyuk - any thoughts on how to fix this? Or is this is a .NET MAUI Bug? I tried setting different values of Edit: Confirmed to be a .NET MAUI bug dotnet/maui#5396 |
| public partial class XamlBindingPopup : Popup | ||
| { | ||
| public XamlBindingPopup() => InitializeComponent(); | ||
| public XamlBindingPopup(PopupSizeConstants popupSizeConstants) |
There was a problem hiding this comment.
Can we have one example without PopupSize?
What will happen if we don't set the size? I expect to see Medium size popup
| namespace CommunityToolkit.Maui.Sample.Models; | ||
|
|
||
| static class PopupSizeConstants | ||
| public class PopupSizeConstants |
There was a problem hiding this comment.
Probably it should be renamed because it is not Constant.
Can we make make it a configuration with predefined values?
So if I want to set custom size for all small popups, I need to change the config value only once. Example: https://github.com/xamarin/XamarinCommunityToolkit/blob/6a8c500ce087363cff0dd75514dcdf15de6f407d/src/CommunityToolkit/Xamarin.CommunityToolkit/Views/Snackbar/Options/ToastOptions.shared.cs#L19
|
|
||
| static void RegisterEssentials(in IServiceCollection services) | ||
| { | ||
| services.AddSingleton<IDeviceInfo, DeviceInfoImplementation>(); |
There was a problem hiding this comment.
Does static DeviceInfo use the injected class or does it create a new instance?
DeviceInfo.Current == services.GetService<IDeviceInfo>???
Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com>
…e.cs Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com>
…e.cs Co-authored-by: Vladislav Antonyuk <33021114+VladislavAntonyuk@users.noreply.github.com>
2 participants
Description of Change
This PR makes the following updates for
CommunityToolkit.Maui.Samplesfollowing the release of .NET MAUI Preview 14:Microsoft.Maui.EssentialsInterfacesTextCaseConverterPageColorsConverterPageItemSelectedEventArgsPageItemTappedEventArgsPageBoolToObjectConverterPageListToStringConverterPageTransparentPopupTransparentPopupCSharpMicrosoft.WindowsAppSDKto v1.01