Merged
Conversation
VladislavAntonyuk
approved these changes
Mar 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR implements the missing tests for the following
ColorTo[Type]StringConverters:ColorToRgbStringConverterColorToRgbaStringConverterColorToHexRgbStringConverterColorToHexRgbaStringConverterColorToCmykStringConverterColorToCmykaStringConverterLinked Issues
Color-To-stringConverters #54PR Checklist
approved(bug) orChampioned(feature/proposal)mainat time of PRAdditional information
BaseConverter<TFrom, TTo>ArgumentNullException.ThrowIfNull(targetType);to the following methods:BaseConverter<TFrom, TTo>.Convert()BaseConverter<TFrom, TTo>.ConvertBack()targetTypeof anIValueConvertershould never be null because a value requires a non-nullTypeto be assigned toIsEqualConverter_TestsIsNotEqualConverterunit tests fromIsEqualConverter_Tests.csIsNotEqualConverterunit tests are already covered inIsNotEqualConverter_Tests.csStringToListConverter_TestsListToStringConverterListToStringConverter_TestsIsEqualConverter+IsNotEqualConverterUse
EqualityComparerto compare values.EqualityCompareris the recommended approach for comparing values and is more thorough than the previous implementation that only used.Equals():https://docs.microsoft.com/en-us/dotnet/api/system.collections.generic.equalitycomparer-1.default?view=net-6.0#remarks
StringToListConverterTTofromIEnumerable->IEnumerable<string>StringToListConverteralways returnsIEnumerable<string>.