Skip to content

Add Color-to-String Unit Tests#339

Merged
TheCodeTraveler merged 20 commits intomainfrom
Add-ColorToString-UnitTests
Mar 28, 2022
Merged

Add Color-to-String Unit Tests#339
TheCodeTraveler merged 20 commits intomainfrom
Add-ColorToString-UnitTests

Conversation

@TheCodeTraveler
Copy link
Copy Markdown
Collaborator

@TheCodeTraveler TheCodeTraveler commented Mar 28, 2022

Description of Change

This PR implements the missing tests for the following ColorTo[Type]StringConverters:

  • ColorToRgbStringConverter
  • ColorToRgbaStringConverter
  • ColorToHexRgbStringConverter
  • ColorToHexRgbaStringConverter
  • ColorToCmykStringConverter
  • ColorToCmykaStringConverter

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard

Additional information

BaseConverter<TFrom, TTo>

  • Added ArgumentNullException.ThrowIfNull(targetType); to the following methods:
    • BaseConverter<TFrom, TTo>.Convert()
    • BaseConverter<TFrom, TTo>.ConvertBack()
  • The targetType of an IValueConverter should never be null because a value requires a non-null Type to be assigned to
  • Updated Unit Tests accordingly

IsEqualConverter_Tests

  • Removed IsNotEqualConverter unit tests from IsEqualConverter_Tests.cs
    • The IsNotEqualConverter unit tests are already covered in IsNotEqualConverter_Tests.cs

StringToListConverter_Tests

  • Fixed tests that were incorrectly testing ListToStringConverter
    • Was likely a copy/paste error from ListToStringConverter_Tests

IsEqualConverter + IsNotEqualConverter

StringToListConverter

  • Change TTo from IEnumerable -> IEnumerable<string>
    • The existing logic for StringToListConverter always returns IEnumerable<string>.

@TheCodeTraveler TheCodeTraveler requested a review from pictos March 28, 2022 04:01
@TheCodeTraveler TheCodeTraveler merged commit fbaf619 into main Mar 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the Add-ColorToString-UnitTests branch March 28, 2022 07:22
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Proposal] Color-To-string Converters

2 participants