This repository was archived by the owner on Feb 25, 2026. It is now read-only.
Use expression builder classes#1579
Merged
skendrot merged 19 commits intoCommunityToolkit:masterfrom Nov 9, 2017
Merged
Conversation
Contributor
Author
|
@samoteph Can you make sure the TileControl still works as expected. All functionality in the sample app continues to work but the expressions are rather complex so would love your eyes on them. |
nmetulev
approved these changes
Oct 31, 2017
Contributor
nmetulev
left a comment
There was a problem hiding this comment.
Tested - works as expected
pedrolamas
approved these changes
Nov 2, 2017
Member
pedrolamas
left a comment
There was a problem hiding this comment.
AFAIK, seems to be working fine and has the same behavior before and after the changes!
Contributor
Author
|
@samoteph Any thoughts on the tile control? |
|
This PR is linked to unclosed issues. Please check if one of these issues should be closed: #1578 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #1578
PR Type
Change to use the new expression builder classes for all expression animations
What is the current behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
What is the new behavior?
Does this PR introduce a breaking change?
Other information