Fix acrylic brush noise texture placement #3336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
assigned
Contributor
|
Thanks for the PR @Sergio0694 🚀🚀 CC: @michael-hawker Missing Noise texture
Noise Texture Added
|
michael-hawker
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3112 and #3298
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
AcrylicBrushand the variousPipelineBuilderAPIs to create acrylic brushes are using the incorrect placement for the blend effect adding the noise texture at the end of the pipeline. THis bug was introduced in #3298, as I forgot to update the code there after swapping the way the placement property worked 🤦♂️What is the new behavior?
Fixed the blend effects for acrylic brushes, now the noise texture will correctly be displayed on top.
PR Checklist
Please check if your PR fulfills the following requirements:
Pull Request has been submitted to the documentation repository instructions. Link:Sample in sample app has been added / updated (for bug fixes / features)Icon has been created (if new sample) following the Thumbnail Style Guide and templatesTests for the changes have been added (for bug fixes / features) (if applicable)Header has been added to all new source files (run build/UpdateHeaders.bat)