Add net10.0 and net10.0-windows10.0.17763.0 target frameworks to CommunityToolkit.Mvvm#1191
Add net10.0 and net10.0-windows10.0.17763.0 target frameworks to CommunityToolkit.Mvvm#1191Rolling2405 wants to merge 1 commit intoCommunityToolkit:mainfrom
Conversation
Add net10.0 and net10.0-windows10.0.17763.0 to CommunityToolkit.Mvvm's TargetFrameworks, following the existing LTS-only shipping pattern (net8.0 LTS → net10.0 LTS, skipping net9.0 STS). All existing conditional blocks use IsTargetFrameworkCompatible against 'net8.0-windows10.0.17763.0', which returns true for the new net10.0-windows TFM, so Windows-specific code paths apply automatically. NET8_0_OR_GREATER symbols are true for net10.0 as well, so no source changes are required. Also add net10.0 to CommunityToolkit.Mvvm.Roslyn5000.UnitTests, which was the only MVVM runtime test project not yet targeting net10.0. All 408 tests pass on net10.0. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@Rolling2405 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ), 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, “Project” means any of the projects owned or managed by .NET Foundation and offered under a license “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any “Submission” means the Code and any other copyrightable material Submitted by You, including any 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any 3. Originality of Work. You represent that each of Your Submissions is entirely Your 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else 5. Licenses. a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. 6. Representations and Warranties. You represent that You are legally entitled to grant the above 7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or 8. Information about Submissions. You agree that contributions to Projects and information about 9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and 10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and .NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1. |
|
@dotnet-policy-service agree |
Summary
Adds
et10.0 and
et10.0-windows10.0.17763.0 to CommunityToolkit.Mvvm's TargetFrameworks, following the existing LTS-only shipping pattern (net8.0 LTS → net10.0 LTS, skipping net9.0 STS).
Changes
et10.0;net10.0-windows10.0.17763.0 to TargetFrameworks
et10.0 (was the only MVVM runtime test project missing it; all 408 tests pass)
Why no other changes are needed
All Windows-conditional property groups use IsTargetFrameworkCompatible(..., 'net8.0-windows10.0.17763.0') which returns rue for
et10.0-windows10.0.17763.0 automatically. All NET8_0_OR_GREATER symbols are true for net10.0, so no source code changes are required. The global.json already pins SDK 10.0.101, and CI uses global.json, so no CI changes are needed.
Verification
Built locally with dotnet build src/CommunityToolkit.Mvvm/CommunityToolkit.Mvvm.csproj -warnaserror: 0 warnings, 0 errors, with confirmed output for
et10.0\CommunityToolkit.Mvvm.dll and
et10.0-windows10.0.17763.0\CommunityToolkit.Mvvm.dll.