ci: clean-deploy on tag and skip redundant verify#19
Closed
alexeid wants to merge 1 commit intoCompEvol:masterfrom
Closed
ci: clean-deploy on tag and skip redundant verify#19alexeid wants to merge 1 commit intoCompEvol:masterfrom
alexeid wants to merge 1 commit intoCompEvol:masterfrom
Conversation
- Gate "Build and test" to non-tag pushes (the same mvn verify runs as part of the deploy lifecycle on tag). - Replace two-step `mvn deploy -Prelease -DskipTests` with single `mvn -Prelease clean deploy`. The previous flow left unsigned package outputs in target/ from an earlier run, so the second invocation could deploy artifact bytes that did not match the freshly generated .asc files. Sonatype rejected such tag releases with "Invalid signature" on zip/sources/javadoc while jar/pom verified. A single clean deploy from the tag avoids that.
Member
Author
|
Superseded by replacement PR opened from a CompEvol branch (no longer using a personal fork for migration). Closing this in favour of the new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build and testto non-tag pushes — the samemvn verifyruns as part of the deploy lifecycle on tag, so it was running twice on tag pushes.mvn deploy -Prelease -DskipTestswith singlemvn -Prelease clean deploy. The previous flow could leave unsigned package outputs intarget/from an earlier run, so the second invocation deployed artifact bytes that did not match the freshly generated.ascfiles. Sonatype rejected such tag releases withInvalid signatureonzip/sources/javadocwhilejar/pomverified. A single clean deploy from the tag avoids that.Same fix that landed on
morph-models(db64781),BEASTLabs(a13e75b), andbeast-classic(8baef54).Test plan
Build and testruns (mvn verify), publish step skipped.v*):Build and testskipped,Publish to Maven Centralrunsmvn -Prelease clean deploy.