Nested Machines and Data Updates #468
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Creates copy of World registry key codec for use in DimensionalPos - Swaps machine tile getSpawn to use a DimensionalPos instead of BlockPos - Minor Codec renames - Move CMInternalData into CompactRoomData - RoomData now private, with access limited via CompactRoomData - PSD now calls getSpawn on the room data, instead of fetching entire RD instance and manually setting WSD dirty - Overhaul to DimPos to include a rotation (for spawning) and improve Codec usage (no more string serializing) - TeleEventHandler updated to call CompactRoomData#getInnerBounds - Add extra methods to MathUtil for chunk and BlockPos calculation - New room generation on player first entry improved - Teleportation into rooms now respects spawn rotation - Update unit tests to swap codec references
Mostly operational, needs more refinement to handle data edge cases and multiplayer environments
Toolchain issues are making this harder to implement; will re-evaluate in 1.17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in support for nested machines and multiple external points for machines. This marks a major feature for CM4, and is one of the items for critical path to a full release.