Summary
In tests/e2e/web/specs/onboardingFlow.spec.ts (line 223), the Google account onboarding flow test relies on a brittle workaround:
await app.auth.fillPasswordField('') // The test only passes when this is added...something is weird hereThis empty-password call is a hack to work around a readiness/timing issue in the Google auth UI flow. It makes the test flaky across environments and masks the real problem.
Expected Fix
- Remove the
fillPasswordField('') workaround call.
- Fix the Google auth readiness check in
AuthPage (or app.auth) so the flow deterministically waits for the Google sign-in UI to be ready.
- Replace any implicit timing dependencies with Playwright auto-waiters (e.g., wait for the Google iframe or its email/password input locators to be attached/visible/enabled using
frame.locator(...).waitFor() or expect(locator).toBeVisible()/toBeEnabled()).
- Ensure the readiness method returns only after those locators are ready.
References
Requested by @MartinBraquet
Summary
In
tests/e2e/web/specs/onboardingFlow.spec.ts(line 223), the Google account onboarding flow test relies on a brittle workaround:This empty-password call is a hack to work around a readiness/timing issue in the Google auth UI flow. It makes the test flaky across environments and masks the real problem.
Expected Fix
fillPasswordField('')workaround call.AuthPage(orapp.auth) so the flow deterministically waits for the Google sign-in UI to be ready.frame.locator(...).waitFor()orexpect(locator).toBeVisible()/toBeEnabled()).References
Requested by @MartinBraquet