[Housekeeping] Organizing the test structure and files, adding fix for issue #36 (None descriptive error)#38
Conversation
Added more compatibility questions
Added compatibility question tests and verifications Updated tests to cover Keywords and Headline changes recently made Updated tests to cover all of the big5 personality traits
…es tsconfig/ts-node to test files and imported modules....there was a syntax error: SyntaxError: tests/e2e/web/pages/homePage.ts: Unexpected token (2:0)
…" using .textContent() to prevent flaky tests Added test for entering profile information post signup flow
…esnt run every time something changes
…AndInterest" into "verifySeeking" to match ui changes
…isplay names and usernames
Updated signUp.spec.ts to use new fixture Updated Account information variable names Deleted "deleteUserFixture.ts" as it was incorporated into the "base.ts" file
|
@O-Bots is attempting to deploy a commit to the Compass Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
MartinBraquet
left a comment
MartinBraquet
left a comment
There was a problem hiding this comment.
Nice, much cleaner!
One useful thing you may consider for the future is to DRY the flow through different pages using functions like in tests/e2e/web/specs/signUp.spec.ts:
async function progressToRequiredForm(
homePage: HomePage,
authPage: AuthPage,
account: UserAccountInformation,
onboardingPage: OnboardingPage,
) {
await homePage.gotToHomePage()
await homePage.clickSignUpButton()
await authPage.fillEmailField(account.email)
await authPage.fillPasswordField(account.password)
await authPage.clickSignUpWithEmailButton()
await onboardingPage.clickSkipOnboardingButton()
}Starting from the home page in each test is not modular. If we add a page to the onboarding flow, we would need to update each test. But if we have a function used in each (onboarding) test that brings us from home page to signup to profiles page, we just need to update that one function.
|
I updated a few minor things: |
|
@MartinBraquet How do I pick up your changes and edit them myself? without completing the PR...is that possible? |
|
I pushed on your main branch, so you can just pull them locally in your IDE or via |
|
Lmk when I can merge then! |
|
We are good to merge after CI is over |
| await authPage.fillPasswordField(fakerAccount.password) | ||
| await authPage.clickSignUpWithEmailButton() | ||
| await onboardingPage.clickSkipOnboardingButton() | ||
| await progressToRequiredForm(homePage,authPage,fakerAccount,onboardingPage) |
2 participants
Description