Add platform-specific builds to goreleaser by Copilot · Pull Request #409 · CompassSecurity/pipeleek

Copilot · 2025-12-01T14:04:57Z

Original prompt

This section details on the original issue you should resolve

<issue_title>Subcommand builds</issue_title>
<issue_description>Extend the goreleaser build process, to create one main build as it is right now and newly add a build per platform. so e.g. gitlab has its own binary, github cmd has its own binary etc. update the make file as well. </issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Subcommand builds #318

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: frjcomp <107982661+frjcomp@users.noreply.github.com>

frjcomp · 2025-12-02T06:48:29Z

@copilot Identify shared code/logic in the new main.go files and extract them to a shared common place.

Copilot

Pull request overview

This PR extends the build system to produce platform-specific standalone binaries alongside the main pipeleak binary. Each platform binary (pipeleak-gitlab, pipeleak-github, pipeleak-bitbucket, pipeleak-devops, pipeleak-gitea) exposes only that platform's commands as the root, simplifying usage for single-platform deployments.

Key Changes:

Added 5 new platform-specific entry points with self-contained logging and terminal handling
Extended goreleaser configuration to build all platform binaries for Linux/Windows on amd64/arm64
Updated Makefile with individual build targets and consolidated build-all target

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 21 comments.

Show a summary per file

File	Description
goreleaser.yaml	Added build configurations for 5 platform-specific binaries with appropriate ldflags for version info
cmd/pipeleak-gitlab/main.go	New GitLab-only entry point with standalone CLI initialization and logging setup
cmd/pipeleak-github/main.go	New GitHub-only entry point with standalone CLI initialization and logging setup
cmd/pipeleak-bitbucket/main.go	New BitBucket-only entry point with standalone CLI initialization and logging setup
cmd/pipeleak-devops/main.go	New Azure DevOps-only entry point with standalone CLI initialization and logging setup
cmd/pipeleak-gitea/main.go	New Gitea-only entry point with standalone CLI initialization and logging setup
Makefile	Added individual `build-{platform}` targets and `build-all` aggregator; updated clean target
.gitignore	Added patterns to ignore all new platform-specific binaries and their Windows .exe variants

Copilot · 2025-12-02T06:50:36Z

+}
+
+func initLogger(cmd *cobra.Command) {
+	defaultOut := os.Stdout


Missing CustomWriter wrapper for proper cross-platform newline handling. The original internal/cmd/root.go uses a CustomWriter type (lines 88-117) that ensures proper newline handling across platforms (different behavior for Windows vs. Unix). Without this wrapper, log output may have incorrect line endings on Windows.

Change:

defaultOut := os.Stdout

To:

defaultOut := &CustomWriter{Writer: os.Stdout}

And update line 132:

defaultOut = runLogFile

To:

defaultOut = &CustomWriter{Writer: runLogFile}

You'll need to add the CustomWriter implementation from internal/cmd/root.go (lines 88-117) to this file or refactor to share the common code.

Copilot · 2025-12-02T06:50:36Z

+		runLogFile, err := os.OpenFile(
+			LogFile,
+			os.O_APPEND|os.O_CREATE|os.O_WRONLY,
+			0600,


Use the named constant format.FileUserReadWrite instead of the magic number 0600 for file permissions. This is consistent with the original internal/cmd/root.go implementation (line 139) and improves maintainability. The constant is already defined in pkg/format/fileperms.go for this purpose.

Change:

0600,

To:

format.FileUserReadWrite,

(Note: You'll need to import "github.com/CompassSecurity/pipeleak/pkg/format")

Copilot · 2025-12-02T06:50:37Z

+}
+
+func initLogger(cmd *cobra.Command) {
+	defaultOut := os.Stdout


Missing CustomWriter wrapper for proper cross-platform newline handling. The original internal/cmd/root.go uses a CustomWriter type (lines 88-117) that ensures proper newline handling across platforms (different behavior for Windows vs. Unix). Without this wrapper, log output may have incorrect line endings on Windows.

Change:

defaultOut := os.Stdout

To:

defaultOut := &CustomWriter{Writer: os.Stdout}

And update line 132:

defaultOut = runLogFile

To:

defaultOut = &CustomWriter{Writer: runLogFile}

You'll need to add the CustomWriter implementation from internal/cmd/root.go (lines 88-117) to this file or refactor to share the common code.

Copilot · 2025-12-02T06:50:37Z

+type TerminalRestoringWriter struct {
+	underlying io.Writer
+}
+
+func (w *TerminalRestoringWriter) Write(p []byte) (n int, err error) {
+	var logEntry map[string]interface{}
+	if err := json.Unmarshal(p, &logEntry); err == nil {
+		if level, ok := logEntry["level"].(string); ok && level == "fatal" {
+			_, _ = w.underlying.Write(p)
+			restoreTerminalState()
+			os.Exit(1)
+		}
+	}
+	return w.underlying.Write(p)
+}
+


TerminalRestoringWriter is defined but never used in this file. The Write method implementation (lines 39-49) handles fatal log detection and terminal restoration, but no code in this file creates instances of this type or calls its methods. This appears to be vestigial code from copying the original cmd/pipeleak/main.go.

Consider removing this unused type or documenting its intended purpose if it's meant for future use.

Suggested change

type TerminalRestoringWriter struct {

underlying io.Writer

}

func (w *TerminalRestoringWriter) Write(p []byte) (n int, err error) {

var logEntry map[string]interface{}

if err := json.Unmarshal(p, &logEntry); err == nil {

if level, ok := logEntry["level"].(string); ok && level == "fatal" {

_, _ = w.underlying.Write(p)

restoreTerminalState()

os.Exit(1)

}

}

return w.underlying.Write(p)

}

Copilot · 2025-12-02T06:50:37Z

+		runLogFile, err := os.OpenFile(
+			LogFile,
+			os.O_APPEND|os.O_CREATE|os.O_WRONLY,
+			0600,


Use the named constant format.FileUserReadWrite instead of the magic number 0600 for file permissions. This is consistent with the original internal/cmd/root.go implementation (line 139) and improves maintainability. The constant is already defined in pkg/format/fileperms.go for this purpose.

Change:

0600,

To:

format.FileUserReadWrite,

(Note: You'll need to import "github.com/CompassSecurity/pipeleak/pkg/format")

Copilot · 2025-12-02T06:50:41Z

+type TerminalRestoringWriter struct {
+	underlying io.Writer
+}
+
+func (w *TerminalRestoringWriter) Write(p []byte) (n int, err error) {
+	var logEntry map[string]interface{}
+	if err := json.Unmarshal(p, &logEntry); err == nil {
+		if level, ok := logEntry["level"].(string); ok && level == "fatal" {
+			_, _ = w.underlying.Write(p)
+			restoreTerminalState()
+			os.Exit(1)
+		}
+	}
+	return w.underlying.Write(p)
+}
+


TerminalRestoringWriter is defined but never used in this file. The Write method implementation (lines 39-49) handles fatal log detection and terminal restoration, but no code in this file creates instances of this type or calls its methods. This appears to be vestigial code from copying the original cmd/pipeleak/main.go.

Consider removing this unused type or documenting its intended purpose if it's meant for future use.

Suggested change

type TerminalRestoringWriter struct {

underlying io.Writer

}

func (w *TerminalRestoringWriter) Write(p []byte) (n int, err error) {

var logEntry map[string]interface{}

if err := json.Unmarshal(p, &logEntry); err == nil {

if level, ok := logEntry["level"].(string); ok && level == "fatal" {

_, _ = w.underlying.Write(p)

restoreTerminalState()

os.Exit(1)

}

}

return w.underlying.Write(p)

}

Copilot · 2025-12-02T06:50:41Z

+type TerminalRestoringWriter struct {
+	underlying io.Writer
+}
+
+func (w *TerminalRestoringWriter) Write(p []byte) (n int, err error) {
+	var logEntry map[string]interface{}
+	if err := json.Unmarshal(p, &logEntry); err == nil {
+		if level, ok := logEntry["level"].(string); ok && level == "fatal" {
+			_, _ = w.underlying.Write(p)
+			restoreTerminalState()
+			os.Exit(1)
+		}
+	}
+	return w.underlying.Write(p)
+}
+


TerminalRestoringWriter is defined but never used in this file. The Write method implementation (lines 39-49) handles fatal log detection and terminal restoration, but no code in this file creates instances of this type or calls its methods. This appears to be vestigial code from copying the original cmd/pipeleak/main.go.

Consider removing this unused type or documenting its intended purpose if it's meant for future use.

Suggested change

type TerminalRestoringWriter struct {

underlying io.Writer

}

func (w *TerminalRestoringWriter) Write(p []byte) (n int, err error) {

var logEntry map[string]interface{}

if err := json.Unmarshal(p, &logEntry); err == nil {

if level, ok := logEntry["level"].(string); ok && level == "fatal" {

_, _ = w.underlying.Write(p)

restoreTerminalState()

os.Exit(1)

}

}

return w.underlying.Write(p)

}

Copilot · 2025-12-02T06:50:41Z

+		output := zerolog.ConsoleWriter{
+			Out:        defaultOut,
+			TimeFormat: "2006-01-02T15:04:05Z07:00",
+			NoColor:    !colorEnabled,
+		}


Missing custom FormatLevel for the "hit" log level coloring. The original internal/cmd/root.go includes a formatLevelWithHitColor function (lines 178-216) that provides magenta coloring for the special "hit" log level used to mark detected secrets. Without this formatter, the "hit" level will not be distinctly colored in console output, making it harder to spot secrets in the logs.

The platform-specific binaries should either:

Include the same formatLevelWithHitColor implementation, or

Refactor to share the common logging setup (as suggested in the code duplication comment)

Current code:

output := zerolog.ConsoleWriter{ Out: defaultOut, TimeFormat: "2006-01-02T15:04:05Z07:00", NoColor: !colorEnabled, }

Should be:

output := zerolog.ConsoleWriter{ Out: defaultOut, TimeFormat: time.RFC3339, // Also use the named constant NoColor: !colorEnabled, FormatLevel: formatLevelWithHitColor(colorEnabled), // Add custom formatter }

Copilot · 2025-12-02T06:50:42Z

+		output := zerolog.ConsoleWriter{
+			Out:        defaultOut,
+			TimeFormat: "2006-01-02T15:04:05Z07:00",
+			NoColor:    !colorEnabled,
+		}


Missing custom FormatLevel for the "hit" log level coloring. The original internal/cmd/root.go includes a formatLevelWithHitColor function (lines 178-216) that provides magenta coloring for the special "hit" log level used to mark detected secrets. Without this formatter, the "hit" level will not be distinctly colored in console output, making it harder to spot secrets in the logs.

The platform-specific binaries should either:

Include the same formatLevelWithHitColor implementation, or

Refactor to share the common logging setup (as suggested in the code duplication comment)

Current code:

output := zerolog.ConsoleWriter{ Out: defaultOut, TimeFormat: "2006-01-02T15:04:05Z07:00", NoColor: !colorEnabled, }

Should be:

output := zerolog.ConsoleWriter{ Out: defaultOut, TimeFormat: time.RFC3339, // Also use the named constant NoColor: !colorEnabled, FormatLevel: formatLevelWithHitColor(colorEnabled), // Add custom formatter }

Copilot · 2025-12-02T06:50:42Z

+}
+
+func initLogger(cmd *cobra.Command) {
+	defaultOut := os.Stdout


Missing CustomWriter wrapper for proper cross-platform newline handling. The original internal/cmd/root.go uses a CustomWriter type (lines 88-117) that ensures proper newline handling across platforms (different behavior for Windows vs. Unix). Without this wrapper, log output may have incorrect line endings on Windows.

Change:

defaultOut := os.Stdout

To:

defaultOut := &CustomWriter{Writer: os.Stdout}

And update line 132:

defaultOut = runLogFile

To:

defaultOut = &CustomWriter{Writer: runLogFile}

You'll need to add the CustomWriter implementation from internal/cmd/root.go (lines 88-117) to this file or refactor to share the common code.

…tions Co-authored-by: frjcomp <107982661+frjcomp@users.noreply.github.com>

Copilot · 2025-12-02T06:55:56Z

@copilot Identify shared code/logic in the new main.go files and extract them to a shared common place.

Extracted shared code to internal/cmd/common package in commit 0df2d5f. Each platform main.go was reduced from ~194 lines to ~29 lines. The common package contains terminal state management, logging setup, common flags, and version information.

frjcomp · 2025-12-02T07:01:09Z

@copilot the goreleaser action should only build all binaries on a release. if it runs on a PR its ok to just build the main binary that includes all platfporms.

Co-authored-by: frjcomp <107982661+frjcomp@users.noreply.github.com>

Copilot · 2025-12-02T07:05:00Z

@copilot the goreleaser action should only build all binaries on a release. if it runs on a PR its ok to just build the main binary that includes all platfporms.

Added skip: '{{ not .IsRelease }}' to all platform-specific builds in commit b388815. Now only the main pipeleak binary is built on PRs/snapshots, while all platform binaries are built on tagged releases.

frjcomp · 2025-12-02T07:07:42Z

@copilot Ensure that the HIT log keeps the color, you somehow removed it.

…mon package Co-authored-by: frjcomp <107982661+frjcomp@users.noreply.github.com>

Copilot · 2025-12-02T07:11:58Z

@copilot Ensure that the HIT log keeps the color, you somehow removed it.

Added formatLevelWithHitColor function to the common package in commit 22ab916. The HIT log level now has magenta coloring (color 35) to distinguish it from other log levels. Also added CustomWriter for proper cross-platform newline handling and used format.FileUserReadWrite constant for file permissions.

Initial plan

0310605

Copilot AI assigned Copilot and frjcomp Dec 1, 2025

Copilot started work on behalf of frjcomp December 1, 2025 14:05 View session

Add platform-specific builds for goreleaser and Makefile

9217e65

Co-authored-by: frjcomp <107982661+frjcomp@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Extend goreleaser build process for platform binaries~~ Add platform-specific builds to goreleaser Dec 1, 2025

Copilot AI requested a review from frjcomp December 1, 2025 14:23

Copilot finished work on behalf of frjcomp December 1, 2025 14:23

frjcomp requested a review from Copilot December 2, 2025 06:40

Copilot started reviewing on behalf of frjcomp December 2, 2025 06:41 View session

Copilot finished reviewing on behalf of frjcomp December 2, 2025 06:45

frjcomp marked this pull request as ready for review December 2, 2025 06:48

Copilot started work on behalf of frjcomp December 2, 2025 06:48 View session

Copilot AI reviewed Dec 2, 2025

View reviewed changes

Extract shared code to internal/cmd/common package and update descrip…

0df2d5f

…tions Co-authored-by: frjcomp <107982661+frjcomp@users.noreply.github.com>

Copilot finished work on behalf of frjcomp December 2, 2025 06:59

Copilot started work on behalf of frjcomp December 2, 2025 07:01 View session

Skip platform-specific builds on non-release (PR/snapshot) builds

b388815

Co-authored-by: frjcomp <107982661+frjcomp@users.noreply.github.com>

Copilot finished work on behalf of frjcomp December 2, 2025 07:06

Copilot started work on behalf of frjcomp December 2, 2025 07:08 View session

Add HIT log level coloring and cross-platform newline handling to com…

22ab916

…mon package Co-authored-by: frjcomp <107982661+frjcomp@users.noreply.github.com>

Copilot finished work on behalf of frjcomp December 2, 2025 07:13

frjcomp added 2 commits December 2, 2025 07:41

fix releaser

f5c4b34

update cont

4eadf74

frjcomp enabled auto-merge (squash) December 2, 2025 08:01

frjcomp merged commit 79bcd93 into main Dec 2, 2025
11 checks passed

frjcomp deleted the copilot/extend-build-process-for-platforms branch December 2, 2025 08:06

Conversation

Copilot AI commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comments on the Issue (you are @copilot in this section)

Uh oh!

frjcomp commented Dec 2, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Dec 2, 2025

Uh oh!

frjcomp commented Dec 2, 2025

Uh oh!

Copilot AI commented Dec 2, 2025

Uh oh!

frjcomp commented Dec 2, 2025

Uh oh!

Copilot AI commented Dec 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Dec 1, 2025 •

edited

Loading