Remove override-true-all-profile-* tests#11077
Merged
jan-cerny merged 1 commit intoComplianceAsCode:masterfrom Sep 8, 2023
Merged
Remove override-true-all-profile-* tests#11077jan-cerny merged 1 commit intoComplianceAsCode:masterfrom
jan-cerny merged 1 commit intoComplianceAsCode:masterfrom
Conversation
This is now covered by test_profile_to_xml_element
|
Code Climate has analyzed commit d00185b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.8% (0.0% change). View more on Code Climate. |
jan-cerny
approved these changes
Sep 8, 2023
Collaborator
jan-cerny
left a comment
There was a problem hiding this comment.
Nice discovery! I confirm that the test data in the test tests/unit/ssg-module/test_build_yaml.py in tests/unit/ssg-module/data/ospp.xml contain <title> and <description> element with override attributes both set to true, which ensures that the method Profile.to_xml_element() will contain these attributes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Removes the override-true-all-profile-* tests from the project.
Rationale:
Fixes #11051
During the review #11075 it was discussed that we cover this in the Profile unit tests.
I believe that this is now covered by
test_profile_to_xml_elementintests/unit/ssg-module/test_build_yaml.py.