Fix chrony remediation to use confdir instead of include#14636
Merged
yuumasato merged 1 commit intoComplianceAsCode:masterfrom Apr 10, 2026
Merged
Conversation
The OVAL check for chronyd_specify_remote_server was updated in 6c23929 to parse confdir/sourcedir directives instead of scanning chrony.d directly. The remediation still used "include /etc/chrony.d/*.conf" which the OVAL check does not follow, causing the rule to FAIL after remediation. Replace "include /etc/chrony.d/*.conf" with "confdir /etc/chrony.d" which is functionally equivalent for chrony and is recognized by the OVAL check. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@Vincent056: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
yuumasato
added a commit
to yuumasato/scap-security-guide
that referenced
this pull request
Apr 11, 2026
…remediation-confdir Fix chrony remediation to use confdir instead of include
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chronyd_specify_remote_serverwas refactored in 6c23929 to parseconfdir/sourcedirdirectives fromchrony.confto locate NTP server entries in sub-config files.include /etc/chrony.d/*.conf, which the updated OVAL does not follow, causing the rule to FAIL after remediation despite servers being correctly configured.include /etc/chrony.d/*.confwithconfdir /etc/chrony.d— functionally equivalent for chrony and recognized by the OVAL check.