Optimize OVALs in multiple rules to avoid errors caused by non-UTF file names#14712
Merged
Conversation
This change should help avoid issues with PCRE when file names contain non-UTF characters. A test scenario simulating this situation has been added. Related to: https://redhat.atlassian.net/browse/RHEL-171005
This change should help avoid issues with PCRE when file names contain non-UTF characters. A test scenario simulating this situation has been added. Related to: https://redhat.atlassian.net/browse/RHEL-171005
This change should help avoid issues with PCRE when file names contain non-UTF characters. A test scenario simulating this situation has been added. Related to: https://redhat.atlassian.net/browse/RHEL-171005
This change should help avoid issues with PCRE when file names contain non-UTF characters. A test scenario simulating this situation has been added. Related to: https://redhat.atlassian.net/browse/RHEL-171005
This change should help avoid issues with PCRE when file names contain non-UTF characters. A test scenario simulating this situation has been added. Related to: https://redhat.atlassian.net/browse/RHEL-171005
This change should help avoid issues with PCRE when file names contain non-UTF characters. A test scenario simulating this situation has been added. Related to: https://redhat.atlassian.net/browse/RHEL-171005
This change should help avoid issues with PCRE when file names contain non-UTF characters. A test scenario simulating this situation has been added. Related to: https://redhat.atlassian.net/browse/RHEL-171005
This change should help avoid issues with PCRE when file names contain non-UTF characters. A test scenario simulating this situation has been added. Related to: https://redhat.atlassian.net/browse/RHEL-171005
This change should help avoid issues with PCRE when file names contain non-UTF characters. A test scenario simulating this situation has been added. Related to: https://redhat.atlassian.net/browse/RHEL-171005
This change should help avoid issues with PCRE when file names contain non-UTF characters. A test scenario simulating this situation has been added. Related to: https://redhat.atlassian.net/browse/RHEL-171005
This change should help avoid issues with PCRE when file names contain non-UTF characters. A test scenario simulating this situation has been added. Related to: https://redhat.atlassian.net/browse/RHEL-171005
This change should help avoid issues with PCRE when file names contain non-UTF characters. A test scenario simulating this situation has been added. Related to: https://redhat.atlassian.net/browse/RHEL-171005
This change should help avoid issues with PCRE when file names contain non-UTF characters. A test scenario simulating this situation has been added. Related to: https://redhat.atlassian.net/browse/RHEL-171005
jan-cerny
requested review from
Mab879,
matusmarhefka and
vojtapolasek
as code owners
|
@jan-cerny: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Mab879
approved these changes
May 13, 2026
Member
|
The testing farm errors are not caused by this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR applies the change that we did in rule
audit_rules_privileged_commandsin #14706 to other rules that contain a similar check in OVAL. All contain a regular expression in thefilenameelement that matches any file name.Test scenarios simulating this situation has been added.
Related to: https://redhat.atlassian.net/browse/RHEL-171005
This PR doesn't solve the problem with non-UTF characters. But, it will avoid this problem in some situations. That will reduce the amount of errors that the user experiences.