Ensure all products are built in CI#14756
Open
Mab879 wants to merge 2 commits into
Open
Conversation
Mab879
added
Infrastructure
Collaborator
|
@Mab879 I think we need to add |
jan-cerny
reviewed
Jun 4, 2026
| ## Phase 8: Build and verify | ||
| ## Phase 8: Add to CI | ||
| The product shall be built in at least one GitHub Action Gate job. | ||
| Ensure that the new product is built and ctest is ran with the product built. |
Collaborator
There was a problem hiding this comment.
Suggested change
| Ensure that the new product is built and ctest is ran with the product built. | |
| Ensure that the new product is built and ctest is run with the product built. |
| All products should be built in CI to ensure a smooth release process. | ||
|
|
||
|
|
||
| Review `.github/workflows/gate.yml` and `.github/workflows/gate_fedora.yml` to find prorper place to add your product. |
Collaborator
There was a problem hiding this comment.
Suggested change
| Review `.github/workflows/gate.yml` and `.github/workflows/gate_fedora.yml` to find prorper place to add your product. | |
| Review `.github/workflows/gate.yml` and `.github/workflows/gate_fedora.yml` to find proper place to add your product. |
|
|
||
|
|
||
| Review `.github/workflows/gate.yml` and `.github/workflows/gate_fedora.yml` to find prorper place to add your product. | ||
| If you struggling to find place to add your new product add it to `.github/workflows/gate_fedora.yml`. |
Collaborator
There was a problem hiding this comment.
Suggested change
| If you struggling to find place to add your new product add it to `.github/workflows/gate_fedora.yml`. | |
| If you are struggling to find place to add your new product add it to `.github/workflows/gate_fedora.yml`. |
|
@Mab879: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Ensure all products are built in CI
Rationale:
Make the release easier
Review Hints:
Ensure that all products are built in CI.