Fix DOM XSS vulnerabilities in control-detail.html#14760
Merged
Conversation
Replace innerHTML string interpolation with DOM API calls to prevent unsanitized URL parameters and localStorage data from executing as HTML.
|
@ggbecker: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
jan-cerny
approved these changes
Jun 4, 2026
Collaborator
jan-cerny
left a comment
jan-cerny
left a comment
There was a problem hiding this comment.
I reproduced the vulnerabilities, then, I checked out this PRs branch and I verified that the vulnerabilities stopped occurring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
Review Hints:
Testing the NIST Control Viewer
The OSCAL catalog data is already present under
utils/nist_sync/data/.Generate the HTML files
cd /path/to/content python3 utils/nist_sync/generate_nist_viewer.py \ --output-dir /tmp/nist-viewer \ --products rhel9Open in a browser
Or navigate directly to a control:
Verify the XSS fix
####### URL parameter injection
Navigate to the following URL and confirm the payload renders as plain text, with no alert dialog:
Expected: the "not found" message displays the literal string
<img src=x onerror=alert(1)>.Todo input injection
Open a valid control page, e.g.
?id=ac-1.Add a todo item with the following text:
Confirm the item appears as plain text in the list with no script execution.