logging_services_active: add syslog-ng as a recognized logging service#14777
Open
israel-villar wants to merge 1 commit into
Open
logging_services_active: add syslog-ng as a recognized logging service#14777israel-villar wants to merge 1 commit into
israel-villar wants to merge 1 commit into
Conversation
The OVAL check and description only listed rsyslog and systemd-journald. Add syslog-ng to the unit pattern so the rule passes on systems that use syslog-ng as their primary logging daemon (e.g. Debian 13 CIS profile). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Hi @israel-villar. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OVAL check and description only listed rsyslog and systemd-journald. Add syslog-ng to the unit pattern so the rule passes on systems that use syslog-ng as their primary logging daemon (e.g. Debian 13 CIS profile).
Description:
Add
syslog-ngto the systemd unit pattern in thelogging_services_activeOVAL check and to the example command in the rule description.
Previously the rule only recognized
rsyslogandsystemd-journaldasvalid active logging services. Systems that use syslog-ng as their primary
logging daemon (e.g. Debian 13 with the CIS profile) would fail this check
even when a logging service is correctly active.
Rationale:
"at least one logging service is active", so syslog-ng should be included
alongside rsyslog and systemd-journald.
Review Hints: