Add Debian 13 support to NTP/chrony rules#14780
Open
israel-villar wants to merge 1 commit into
Open
Conversation
- chronyd_run_as_chrony_user: add bash/debian.sh that sets the chrony user to _chrony (Debian uses _chrony, not chrony); extend OVAL condition from ubuntu-only to all Debian products to check /etc/chrony/chrony.conf. - service_chronyd_disabled: extend the service_disabled_guard_var condition from ubuntu-only to all Debian products. Remove now-dead servicename@ubuntu2204 and servicename@debian12 overrides from the service_disabled branch (those products now use service_disabled_guard_var). - service_timesyncd_disabled: extend service_disabled_guard_var condition to all Debian products. - service_timesyncd_configured: fix platform from package[systemd] to package[systemd-timesyncd] (the timesyncd package is split on Debian). - package_timesyncd_installed: extend package_installed_guard_var condition from ubuntu-only to all Debian products. - chronyd_configure_pool_and_server: fix OVAL and Ansible regexps to allow options after the server/pool address (e.g. "iburst", "maxpoll"); add two test scenarios covering pool/server entries with options. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Hi @israel-villar. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Extend NTP and chrony rules to support Debian 13:
chronyd_run_as_chrony_user: addbash/debian.shthat sets theruntime user to
_chrony(Debian convention); extend OVAL conditionfrom ubuntu-only to all Debian products to read
/etc/chrony/chrony.conf.service_chronyd_disabled: extend theservice_disabled_guard_varcondition from ubuntu-only to all Debian products; remove now-dead
servicename@ubuntu2204andservicename@debian12overrides.service_timesyncd_disabled: extendservice_disabled_guard_varcondition to all Debian products.
service_timesyncd_configured: fix platform frompackage[systemd]to
package[systemd-timesyncd](timesyncd is a split package on Debian).package_timesyncd_installed: extendpackage_installed_guard_varcondition from ubuntu-only to all Debian products.
chronyd_configure_pool_and_server: fix OVAL and Ansible regexps toallow options after the server/pool address (e.g.
iburst,maxpoll);add two test scenarios covering pool/server entries with options.
Rationale:
Debian 13 uses
_chronyas the chrony runtime user (notchrony),systemd-timesyncdis packaged separately, and chrony configurationaccepts options on the same line as
server/pooldirectives thatthe previous regexp did not match.
Review Hints:
chronyd_run_as_chrony_user/bash/debian.sh: new file, sets_chrony.chronyd_configure_pool_and_server: regexp change — old patternrequired end-of-line immediately after the address; new pattern allows
optional trailing content (
([[:space:]].*)?$).pool_with_options.pass.sh,server_with_options.pass.sh) verify the fixed regexp.