Add Debian 13 PAM support to existing rules#14781
Open
israel-villar wants to merge 1 commit into
Open
Conversation
Add Debian-specific bash remediations and OVAL checks for PAM rules that previously lacked Debian support: - accounts_password_pam_pwhistory_remember: add bash/debian.sh and oval/debian.xml using /etc/pam.d/common-password directly. - accounts_password_pam_pwhistory_use_authtok: add bash/debian.sh. - accounts_password_pam_unix_authtok: add bash/debian.sh. - accounts_password_pam_pwquality_enabled: add oval/debian.xml checking pam_pwquality.so in /etc/pam.d/common-password. Extend existing shared remediations to cover Debian: - accounts_password_pam_unix_enabled/bash/shared.sh: add multi_platform_debian. - accounts_password_pam_pwhistory_enabled/bash/shared.sh: add multi_platform_debian. - accounts_passwords_pam_faillock_enabled/bash/shared.sh: add multi_platform_debian. - accounts_password_pam_unix_no_remember/bash/shared.sh: add multi_platform_debian. - no_empty_passwords_unix/bash/shared.sh: add fallback that removes nullok directly from /etc/pam.d/common-* files in case pam-auth-update is blocked by local modifications. Add CIS Debian 13 options to password hashing algorithm variables: - var_password_hashing_algorithm.var: add cis_debian13=YESCRYPT|SHA512 - var_password_hashing_algorithm_pam.var: add cis_debian13=yescrypt|sha512 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Hi @israel-villar. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Debian-specific bash remediations and OVAL checks for PAM rules that previously lacked Debian support:
Extend existing shared remediations to cover Debian:
Add CIS Debian 13 options to password hashing algorithm variables:
Description:
Add Debian-specific bash remediations and OVAL checks for PAM rules that
previously lacked Debian support:
accounts_password_pam_pwhistory_remember: addbash/debian.shandoval/debian.xmlusing/etc/pam.d/common-passworddirectly.accounts_password_pam_pwhistory_use_authtok: addbash/debian.sh.accounts_password_pam_unix_authtok: addbash/debian.sh.accounts_password_pam_pwquality_enabled: addoval/debian.xmlchecking
pam_pwquality.soin/etc/pam.d/common-password.Extend existing shared remediations to cover Debian:
accounts_password_pam_unix_enabled/bash/shared.sh: addmulti_platform_debian.accounts_password_pam_pwhistory_enabled/bash/shared.sh: addmulti_platform_debian.accounts_passwords_pam_faillock_enabled/bash/shared.sh: addmulti_platform_debian.accounts_password_pam_unix_no_remember/bash/shared.sh: addmulti_platform_debian.no_empty_passwords_unix/bash/shared.sh: add fallback that removesnullokdirectly from/etc/pam.d/common-*files whenpam-auth-updateis blocked by local modifications.
Add CIS Debian 13 options to password hashing algorithm variables:
var_password_hashing_algorithm.var: addcis_debian13=YESCRYPT|SHA512var_password_hashing_algorithm_pam.var: addcis_debian13=yescrypt|sha512Rationale:
Debian uses
/etc/pam.d/common-*files managed bypam-auth-update.Rules that previously only had RHEL/SLE remediations needed Debian-specific
implementations that edit these files directly. The
nullokfallback isneeded because
pam-auth-updatemay refuse to run when local modificationsare detected.
Review Hints:
fix/debian-pam-pwquality-remediation(already open), which fixes
accounts_password_pam_pwquality_enabled/bash/shared.shand
shared/templates/accounts_password/bash.template. No file overlap.yescryptas the default password hashing algorithm(Debian 13 default);
SHA512is the legacy fallback allowed by CIS.