CMP-4339: Added documentation_complete: true tags to rules that were missing it#14810
Conversation
|
Hi @abushkin-redhat. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Mab879
left a comment
Mab879
left a comment
There was a problem hiding this comment.
Thanks for the PR. See my notes below.
- Please rebase this pull request to remove the merge commit.
- Please consider split this PR into
documentation_completeand the other changes.
|
@Mab879 Thanks for catching that! I didn't realize this PR had pulled in those other things 😅 |
…_complete' tag entirely to 'documentation_complete:true' for rules that are pulled into profiles.
abushkin-redhat
force-pushed
the
cmp-4339-documentation-complete
branch
from
5d1f477 to
86eb9e0
Compare
|
/retest |
|
/packit retest-failed |
|
/test 4.22-e2e-aws-openshift-node-compliance-rhcos10 |
|
@abushkin-redhat: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-aws-openshift-platform-compliance-rhcos10 |
3 participants
Description:
Updated 75 files that were completely missing the
documentation_completetag. These are all files whose rules are pulled into at least one compliance profile. More information can be found here: https://redhat.atlassian.net/browse/CMP-4339.