Allow audit to log read and write#1764
Merged
mpreisler merged 1 commit intoComplianceAsCode:masterfrom Mar 22, 2017
Merged
Conversation
Change OVAL check to allow read and write access logging of audit rules for privileged commands.
Member
|
ACK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves forward with first issue, and fixes second issue of #379
First issue:
Check was improved to match the binaries in
-F path=.*, but was not able to make the regex capture multiple occurrences of it, only the last one.Improving pattern in
object_arpc_suid_sgid_augenrulesandobject_arpc_suid_sgid_auditctlto match all occurrences of the binary path should fix this issue.Second issue:
OVAL check improved to allow read and write logging.