Change yaml.Loader to yaml.SafeLoader#2818
Merged
yuumasato merged 2 commits intoComplianceAsCode:masterfrom May 2, 2018
Merged
Change yaml.Loader to yaml.SafeLoader#2818yuumasato merged 2 commits intoComplianceAsCode:masterfrom
yuumasato merged 2 commits intoComplianceAsCode:masterfrom
Conversation
redhatrises
added
bugfix
mpreisler
reviewed
May 2, 2018
shared/modules/ssgcommon.py
Outdated
|
|
||
| # Don't follow python bool case | ||
| yaml.Loader.add_constructor(u'tag:yaml.org,2002:bool', bool_constructor) | ||
| yaml.SafeLoader.add_constructor(u'tag:yaml.org,2002:bool', bool_constructor) |
Member
There was a problem hiding this comment.
wait... every time we load a yaml we add a constructor to the static class?
Member
There was a problem hiding this comment.
shouldn't this be called right after we import "yaml" module?
Contributor
Author
There was a problem hiding this comment.
@mpreisler it doesn't have to. I moved it to the top after the imports.
|
Hello @redhatrises! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on May 02, 2018 at 15:53 Hours UTC |
redhatrises
force-pushed
the
yaml_safeloader
branch
from
6268a2f to
9d10e93
Compare
redhatrises
force-pushed
the
yaml_safeloader
branch
from
9d10e93 to
6a3b16c
Compare
Member
|
@redhatrises thank you for the fix. I was confused about why it was not working. Selectors are working now. Ack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Rationale: