Fail when the rule provided by --rule-id doesn't exist #4946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When user wants to compare only 1 rule, and the rule isn't present in the datastream, for example the user makes a typo in --rule-id value, the script will fail.
yuumasato
requested changes
Oct 29, 2019
| rules = benchmark.findall( | ||
| ".//xccdf:Rule[@id='%s']" % (rule_id), ns) | ||
| if len(rules) == 0: | ||
| raise ValueError("Can't find rule %s" % (rule_id)) |
Member
There was a problem hiding this comment.
How about catching this exceptions somewhere and printing a nice message instead of tracebacking?
Collaborator
Author
|
I have caught the exception. |
Member
|
@jan-cerny Nice catch. 😆 |
yuumasato
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When an user wants to compare only 1 rule, and the rule isn't present in the datastream, for example the user makes a typo in --rule-id value, the script will fail.
Rationale: