fix build system to correctly parse platforms#6760
Merged
yuumasato merged 3 commits intoComplianceAsCode:masterfrom Mar 29, 2021
Merged
fix build system to correctly parse platforms#6760yuumasato merged 3 commits intoComplianceAsCode:masterfrom
yuumasato merged 3 commits intoComplianceAsCode:masterfrom
Conversation
|
Hello @vojtapolasek! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-03-29 10:00:16 UTC |
Collaborator
|
Changes identified: Show detailsOthers: Recommended tests to execute: |
200d587 to
d94e814
Compare
yuumasato
requested changes
Mar 26, 2021
Member
yuumasato
left a comment
There was a problem hiding this comment.
What do you think about making platforms a set()?
I think it will simplify the code a bit.
Collaborator
Author
|
I pushed changes which initialize platforms as set. They are also stored as set within compiled rules... I am not sure if it breaks something, it looks like not at the first glance. |
yuumasato
requested changes
Mar 29, 2021
b979b38 to
4bb5816
Compare
yuumasato
approved these changes
Mar 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Rationale: