Skip to content

Comments

fix build system to correctly parse platforms#6760

Merged
yuumasato merged 3 commits intoComplianceAsCode:masterfrom
vojtapolasek:fix_cpe_platforms
Mar 29, 2021
Merged

fix build system to correctly parse platforms#6760
yuumasato merged 3 commits intoComplianceAsCode:masterfrom
vojtapolasek:fix_cpe_platforms

Conversation

@vojtapolasek
Copy link
Collaborator

Description:

  • read both "platform" and "platforms" while parsing yaml files
  • then later work only with "platforms" but make sure that content of "platform" gets propagated into "platforms"

Rationale:

@vojtapolasek vojtapolasek added the bugfix Fixes to reported bugs. label Mar 26, 2021
@vojtapolasek vojtapolasek added this to the 0.1.56 milestone Mar 26, 2021
@pep8speaks
Copy link

pep8speaks commented Mar 26, 2021

Hello @vojtapolasek! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-03-29 10:00:16 UTC

@openscap-ci
Copy link
Collaborator

openscap-ci commented Mar 26, 2021

Changes identified:
Others:
 Changes in Python files.

Show details

Others:
 Python abstract syntax tree change found in ssg/build_yaml.py.

Recommended tests to execute:
 (cd build && cmake ../ && ctest -j4)

@yuumasato yuumasato self-assigned this Mar 26, 2021
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about making platforms a set()?
I think it will simplify the code a bit.

@vojtapolasek
Copy link
Collaborator Author

I pushed changes which initialize platforms as set. They are also stored as set within compiled rules... I am not sure if it breaks something, it looks like not at the first glance.

@yuumasato yuumasato merged commit 7e1d936 into ComplianceAsCode:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes to reported bugs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants