-
Notifications
You must be signed in to change notification settings - Fork 766
Convert Bash functions from include_mount_options_functions to separate Jinja macros #7401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipping CI for Draft Pull Request. |
|
It's an elegant solution which would allow you to proceed quickly. But, when I see it, I think it's not friendly to the developers that will want to use it, because they would have to open the macro definition and understand the bash code there. I think we should break it down and create a separate jinja macro for each of the small functions. |
|
@j-ode Also, after you do the changes, please rebase on the latest master. |
|
/retest |
1 similar comment
|
/retest |
|
@j-ode: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Thank you very much for your pull request. |
Description:
Rationale: