SLE15 add use_kerberos_security_all_exports rule to HIPAA profile #7905
Conversation
|
Hi @teacup-on-rockingchair. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This datastream diff is auto generated by the check Click here to see the full diffNew datastream adds bash remediation for rule 'xccdf_org.ssgproject.content_rule_use_kerberos_security_all_exports'.
New datastream adds ansible remediation for rule 'xccdf_org.ssgproject.content_rule_use_kerberos_security_all_exports'. |
| do | ||
| correct_export="" | ||
| if [ "$(grep -c "sec=" <<<"$nfs_export")" -eq 0 ]; then | ||
| correct_export="$(echo $nfs_export|sed -e 's/sec=[^\,\)]*/sec=krb5\:krb5i\:krbp5/')" |
There was a problem hiding this comment.
It should be krb5p, not krbp5.
There was a problem hiding this comment.
Should be fixed in should be fixed in a59ed41
| for nfs_export in "${nfs_exports[@]}" | ||
| do | ||
| correct_export="" | ||
| if [ "$(grep -c "sec=" <<<"$nfs_export")" -eq 0 ]; then |
There was a problem hiding this comment.
You probably swap the command in the if branch with the command in the else branch. If the count of sec= in the string is 0, it won't make sense to try replacing sec= by sed.
| @@ -0,0 +1,3 @@ | |||
| # platform = multi_platform_all | |||
|
|
|||
There was a problem hiding this comment.
Many test scenarios fail when bash remediation is used.
There was a problem hiding this comment.
Thx, obviously there was some bad copy-pasting from my test machine, should be fixed in a59ed41
- Confused logic fixed when to replace sec parameter and when to add - Fixed type on krb5p value Thanks to @jan-cerny for the feedback
2 participants
Description:
Add use_kerberos_security_all_exports to SLE15 HIPAA profile
Rationale:
Add ansible,bash remediation and tests for use_kerberos_security_all_exports