Update tag-name variable in cli-release.yml for correct versioning in brew#705
Update tag-name variable in cli-release.yml for correct versioning in brew#705
Conversation
WalkthroughThis pull request modifies the Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/cli-release.yml (1)
26-47: Consider adding inline comment for maintainability.The distinction between
RELEASE_TAG("cli-$VERSION_NAME") used for GitHub release tags andVERSION_NAMEused for the Homebrew formula version is important context. Consider adding a brief comment in the "Prepare release information" step to explain this separation for future maintainers.- name: Prepare release information run: | VERSION_NAME=$(grep "^cli-version" gradle/cli.versions.toml | cut -d '"' -f 2) + # RELEASE_TAG includes the "cli-" prefix for GitHub releases; VERSION_NAME is clean for Homebrew RELEASE_TAG="cli-$VERSION_NAME"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/cli-release.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build (ubuntu-latest)
No description provided.