Refactor imports to use androidx.compose.ui.tooling.preview.Preview#801
Refactor imports to use androidx.compose.ui.tooling.preview.Preview#801
Conversation
egorikftp
force-pushed
the
task/use-androidx-preview-annotation
branch
from
f963b51 to
cf8b40b
Compare
WalkthroughAdded a new library entry Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
tools/gradle-plugin/build.gradle.kts (1)
74-74: Consider using the library reference directly for better maintainability.The manual construction of the artifact coordinate string works correctly, but using
libs.compose.ui.get().toString()would be more maintainable and eliminate the risk of the artifact coordinate drifting from the catalog definition.🔎 Proposed refactor
- buildConfigField("COMPOSE_UI", "androidx.compose.ui:ui:${libs.versions.compose.get()}") + buildConfigField("COMPOSE_UI", libs.compose.ui.get().toString())
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (59)
gradle/libs.versions.tomltools/gradle-plugin/build.gradle.ktstools/idea-plugin/build.gradle.ktstools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/action/dialog/RequiredIconPackModeDialog.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/common/picker/UniversalPicker.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/DragAndDropBox.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/DropdownMenu.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/FocusableTextField.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/InfoItem.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/InputField.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/PixelGrid.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/ScrollableTabRow.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/TextWithIcon.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/TooltipButton.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/TopAppBar.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/components/previewer/ImageVectorPreviewPanel.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/components/previewer/PreviewParsingError.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/components/previewer/TopActions.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/picker/GenericPickerScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/previewbg/PreviewBackground.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/editor/EditorSelectScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/editor/edit/EditScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/editor/edit/ui/EditorSelectUi.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/intro/IntroScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/IconPackConversionScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/DragAndDropOverlay.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/batch/BatchProcessingStateUi.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/batch/ui/IconPreviewBox.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/batch/ui/ImportIssues.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/picker/IconPackPickerStateUi.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/creation/common/packedit/ui/PackEditUi.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/existingpack/ExistingPackScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/existingpack/ui/foundation/ChooseExistingPackFile.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/existingpack/ui/foundation/ExistingPackEditor.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/newpack/NewPackScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/newpack/ui/foundation/ChoosePackDirectory.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/newpack/ui/foundation/NewPackCreation.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/imagevectortoxml/conversion/ImageVectorToXmlScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/imagevectortoxml/conversion/ui/action/EditActionContent.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/simple/conversion/SimpleConversionScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/simple/conversion/ui/action/EditActionContent.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/simple/conversion/ui/action/PreviewActionContent.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/AboutSettingsScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/GeneralSettingsScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/GeneratorSettingsScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/IndentSizeSection.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/OutputFormatSection.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/PreviewAnnotationSection.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/ui/SelectableCard.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/ui/SwitchOption.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/preview/ImageVectorPreviewSettingsScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/preview/PreviewBgSection.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/WebImportSelectorScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/common/ui/CategoriesDropdown.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/common/ui/SearchInputField.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/common/ui/SidePanel.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/material/ui/FontCustomization.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/material/ui/FontFamilyDropdown.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/material/ui/MaterialTopActions.kt
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-12-07T20:07:49.753Z
Learnt from: egorikftp
Repo: ComposeGears/Valkyrie PR: 750
File: tools/gradle-plugin/src/main/kotlin/io/github/composegears/valkyrie/gradle/internal/task/GenerateImageVectorsTask.kt:71-85
Timestamp: 2025-12-07T20:07:49.753Z
Learning: In the Valkyrie Gradle plugin (Kotlin), the `useFlatPackage` flag in `IconPackExtension` is only applicable when nested packs are configured. For single icon packs (without nested packs), the flag is intentionally not propagated to `ImageVectorGeneratorConfig` as there is no package hierarchy to flatten.
Applied to files:
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/creation/common/packedit/ui/PackEditUi.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/newpack/ui/foundation/NewPackCreation.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/picker/IconPackPickerStateUi.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/newpack/ui/foundation/ChoosePackDirectory.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/existingpack/ExistingPackScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/imagevectortoxml/conversion/ImageVectorToXmlScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/existingpack/ui/foundation/ChooseExistingPackFile.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/newpack/NewPackScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/action/dialog/RequiredIconPackModeDialog.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/existingpack/ui/foundation/ExistingPackEditor.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/components/previewer/ImageVectorPreviewPanel.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/IconPackConversionScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/DragAndDropOverlay.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/batch/BatchProcessingStateUi.kt
📚 Learning: 2025-09-27T22:19:48.762Z
Learnt from: t-regbs
Repo: ComposeGears/Valkyrie PR: 587
File: sdk/generator/xml/src/commonMain/kotlin/io/github/composegears/valkyrie/sdk/generator/xml/XmlSerializer.kt:13-16
Timestamp: 2025-09-27T22:19:48.762Z
Learning: The VectorDrawable.Child sealed interface in the Valkyrie project only has Group and Path as implementations. ClipPath is not implemented in this project, despite being supported in Android's official VectorDrawable specification.
Applied to files:
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/TooltipButton.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/preview/PreviewBgSection.kt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build (ubuntu-latest)
🔇 Additional comments (58)
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/existingpack/ui/foundation/ChooseExistingPackFile.kt (1)
14-14: Preview import refactoring looks good.The change correctly migrates from the desktop-specific
androidx.compose.desktop.ui.tooling.preview.Previewto the standardandroidx.compose.ui.tooling.preview.Preview, aligning with the PR objective to fix preview support in IntelliJ IDEA 2025.3+. The annotation is properly applied to the preview composable function on line 92.Also applies to: 92-92
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/picker/IconPackPickerStateUi.kt (1)
5-5: LGTM! Import migration aligns with PR objectives.The import update from
androidx.compose.desktop.ui.tooling.previewtoandroidx.compose.ui.tooling.previewis correct and necessary for IntelliJ IDEA 2025.3+ preview support. The@Previewannotation usage remains unchanged and the change is consistent with the project-wide migration.tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/simple/conversion/ui/action/PreviewActionContent.kt (1)
9-9: LGTM! Dependency configuration verified.The import change from desktop-specific to standard androidx preview is correct. The
compose-ui-tooling-previewdependency is properly configured in the version catalog (1.10.0) and correctly imported in the idea-plugin build.gradle.kts withcompileOnlyscope. The build configuration also excludes the desktop-specific preview to prevent conflicts. This aligns with the PR objective to support IntelliJ IDEA 2025.3+.tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/newpack/ui/foundation/ChoosePackDirectory.kt (1)
19-19: Import change is correct and properly configured.The migration from
androidx.compose.desktop.ui.tooling.preview.Previewtoandroidx.compose.ui.tooling.preview.Previewis complete and consistent across the codebase. The necessary dependencylibs.compose.ui.tooling.previewis declared withcompileOnly, and the old desktop-specific library is explicitly excluded from the build configuration to prevent conflicts. The@Previewannotation usage at line 116 is compatible with the new import path.tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/creation/common/packedit/ui/PackEditUi.kt (1)
12-12: Preview import migration is correctly applied and properly configured.The import change to
androidx.compose.ui.tooling.preview.Previewis correct and aligns with the PR's IntelliJ IDEA 2025.3+ support objective. The newcompose-ui-tooling-preview:1.10.0dependency is properly declared in gradle/libs.versions.toml, and the simple usage of@Previewwithout parameters (line 177) is fully compatible with the new API.tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/editor/EditorSelectScreen.kt (1)
19-19: LGTM! Preview import correctly updated.The migration from desktop-specific to standard UI tooling Preview annotation is correct and aligns with IntelliJ IDEA 2025.3+ compatibility requirements.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/imagevectortoxml/conversion/ui/action/EditActionContent.kt (1)
12-12: LGTM! Preview import correctly updated.tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/existingpack/ui/foundation/ExistingPackEditor.kt (1)
12-12: LGTM! Preview import correctly updated.tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/InputField.kt (1)
16-16: LGTM! Preview import correctly updated.tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/imagevectortoxml/conversion/ImageVectorToXmlScreen.kt (1)
9-9: Update migration verification: Old Preview imports still exist in test resources and generator code.While the import in this file was correctly updated to
androidx.compose.ui.tooling.preview.Preview, the verification found the oldandroidx.compose.desktop.ui.tooling.preview.Previewstill referenced in:
- 6 test resource files (
sdk/test/sharedTestResources/imagevector/kt/**/*.jetbrains.kt)- 1 generator file (
components/generator/jvm/imagevector/src/main/kotlin/.../Names.kt:31)- 1 documentation comment in gradle plugin
Determine if these remaining references should be migrated or if they are intentional for test fixtures and code generation purposes.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/TopAppBar.kt (1)
19-19: LGTM! Preview import migrated successfully.The import path update is consistent with the project-wide migration to androidx UI tooling Preview annotations.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/newpack/NewPackScreen.kt (1)
15-15: LGTM! Import path updated correctly.The Preview annotation import follows the project-wide migration pattern.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/material/ui/FontFamilyDropdown.kt (1)
5-5: LGTM! Preview import updated.The change is consistent with the androidx UI tooling Preview migration.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/newpack/ui/foundation/NewPackCreation.kt (1)
29-29: LGTM! Preview import migration complete.The import change aligns with the project-wide refactoring to use androidx UI tooling Preview annotations.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/action/dialog/RequiredIconPackModeDialog.kt (1)
15-15: Preview import successfully migrated to androidx UI tooling.The import change in RequiredIconPackModeDialog.kt from desktop-specific to standard androidx.compose.ui.tooling.preview.Preview is correct. Verification confirms all desktop Preview imports have been migrated within the tools/idea-plugin module, aligning with the PR objective to fix preview support for IntelliJ IDEA 2025.3+.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/IconPackConversionScreen.kt (1)
37-37: LGTM – Preview import updated correctly.The migration to the standard androidx UI tooling preview is consistent with the PR's objective.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/IndentSizeSection.kt (1)
25-25: LGTM – Preview import updated correctly.tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/ui/SelectableCard.kt (1)
15-15: LGTM – Preview import updated correctly.tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/common/ui/SidePanel.kt (1)
19-19: LGTM – Preview import updated correctly.tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/material/ui/MaterialTopActions.kt (1)
5-5: LGTM! Clean import refactoring.The import change from the desktop-specific Preview to the standard UI tooling Preview is correct and aligns with IntelliJ IDEA 2025.3+ requirements.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/material/ui/FontCustomization.kt (1)
29-29: LGTM! Import updated correctly.The Preview import change is consistent with the broader refactoring effort across the codebase.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/InfoItem.kt (1)
13-13: LGTM! Import refactored correctly.The Preview annotation import has been successfully migrated to the standard UI tooling package.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/components/previewer/TopActions.kt (1)
14-14: LGTM! Preview import updated successfully.The import change maintains consistency with the project-wide refactoring to support IntelliJ IDEA 2025.3+.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/batch/BatchProcessingStateUi.kt (1)
35-35: LGTM!The import statement
androidx.compose.ui.tooling.preview.Previewis correct and properly used by the@Previewannotation in the preview function. The dependency version 1.10.0 is the latest stable release.tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/preview/PreviewBgSection.kt (1)
32-32: LGTM! Import updated correctly.The Preview import has been successfully migrated from the desktop tooling package to the UI tooling package, aligning with IntelliJ IDEA 2025.3+ support.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/DragAndDropOverlay.kt (1)
20-20: LGTM! Import updated correctly.The Preview import has been successfully migrated to the UI tooling package, consistent with the project-wide refactoring.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/intro/IntroScreen.kt (1)
18-18: LGTM! Import updated correctly.The Preview import change aligns with the project-wide migration to support IntelliJ IDEA 2025.3+.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/common/ui/CategoriesDropdown.kt (1)
5-5: LGTM! Import updated correctly.The Preview import has been successfully migrated to the UI tooling package.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/ScrollableTabRow.kt (1)
29-29: LGTM! Import updated correctly.The Preview import change is consistent with the project-wide refactoring to support IntelliJ IDEA 2025.3+.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/OutputFormatSection.kt (1)
14-14: LGTM! Preview import successfully migrated.The import change from the desktop-specific Preview annotation to the standard UI tooling Preview is correct and aligns with the PR objective to support IntelliJ IDEA 2025.3+.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/WebImportSelectorScreen.kt (1)
13-13: LGTM! Import successfully updated.The Preview annotation import has been correctly migrated to use the standard UI tooling package.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/common/ui/SearchInputField.kt (1)
32-32: LGTM! Import migration is correct.The change correctly updates the Preview annotation import to the UI tooling package.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/common/picker/UniversalPicker.kt (1)
27-27: LGTM! Preview annotation import successfully updated.The import change is correct and consistent with the migration to UI tooling Preview annotations.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/batch/ui/IconPreviewBox.kt (1)
18-18: LGTM! Import correctly migrated.The Preview annotation import has been successfully updated to use the UI tooling package.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/preview/ImageVectorPreviewSettingsScreen.kt (1)
19-19: LGTM: Preview import migration applied correctly.The import change is consistent with the project-wide migration to androidx.compose.ui.tooling.preview.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/components/previewer/ImageVectorPreviewPanel.kt (1)
21-21: LGTM: Preview annotation import updated successfully.The change aligns with the project-wide migration to standard androidx Compose UI tooling preview support.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/picker/GenericPickerScreen.kt (1)
18-18: LGTM: Preview import path updated correctly.The import change is consistent with the broader migration to androidx.compose.ui.tooling.preview across the project.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/existingpack/ExistingPackScreen.kt (1)
15-15: LGTM: Preview import updated as expected.The change is part of the consistent project-wide refactoring to use androidx.compose.ui.tooling.preview for IntelliJ IDEA 2025.3+ compatibility.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/simple/conversion/SimpleConversionScreen.kt (1)
10-10: Import refactoring to standard androidx.compose.ui.tooling.preview.Preview is correct.The change from desktop-specific preview import to the standard androidx version is necessary and appropriate. The desktop preview library (
org.jetbrains.compose.ui:ui-tooling-preview-desktop) is explicitly excluded in the build configuration, and the standard androidx version (1.10.0) is properly defined in gradle/libs.versions.toml.tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/batch/ui/ImportIssues.kt (1)
16-16: LGTM! Import migration to androidx.compose.ui.tooling.preview.The Preview import has been correctly updated from the desktop-specific package to the general UI tooling package, aligning with the broader migration across the project.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/editor/edit/EditScreen.kt (1)
15-15: LGTM! Import migration to androidx.compose.ui.tooling.preview.The Preview import has been correctly updated to use the UI tooling package instead of the desktop-specific variant.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/TooltipButton.kt (1)
20-20: LGTM! Import migration to androidx.compose.ui.tooling.preview.The Preview import has been correctly updated, consistent with the project-wide migration to the UI tooling package.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/components/previewer/PreviewParsingError.kt (1)
21-21: LGTM! Import migration to androidx.compose.ui.tooling.preview.The Preview import has been correctly updated to the UI tooling package, consistent with the broader migration.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/previewbg/PreviewBackground.kt (1)
11-11: LGTM! Import migration to androidx.compose.ui.tooling.preview.The Preview import has been correctly updated, completing the migration pattern seen across the project. Compatibility with IntelliJ IDEA 2025.3 is supported, though preview rendering depends on matching Kotlin and Compose Compiler versions. If preview rendering issues occur, ensure the ui-tooling dependency is present and verify version alignment using the Compose-to-Kotlin compatibility map; check the IDE log (idea.log) for concrete errors, and consider invalidating caches and restarting the IDE if needed.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/ui/SwitchOption.kt (1)
15-15: LGTM! Import updated correctly.The Preview annotation import has been successfully updated to use the non-desktop UI tooling package, consistent with the PR's objective to support IntelliJ IDEA 2025.3+.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/simple/conversion/ui/action/EditActionContent.kt (1)
12-12: LGTM! Import updated correctly.The import path has been properly updated from the desktop-specific tooling package to the standard UI tooling package.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/AboutSettingsScreen.kt (1)
27-27: LGTM! Import updated correctly.The Preview import has been successfully migrated to the UI tooling package as intended.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/GeneralSettingsScreen.kt (1)
30-30: LGTM! Import updated correctly.The Preview annotation import path has been properly updated to use the UI tooling package.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/PreviewAnnotationSection.kt (2)
14-14: LGTM! Import updated correctly.The Preview annotation import has been successfully updated to use the UI tooling package.
57-86: Address incomplete migration of desktop Preview imports.The androidx.compose.ui:ui-tooling-preview:1.10.0 dependency version is confirmed as valid and stable. However, the migration is incomplete:
- Old desktop Preview imports remain in test resources (6 files in
sdk/test/sharedTestResources/imagevector/)- Active source code references to the old import exist in
components/generator/jvm/imagevector/src/main/kotlin/io/github/composegears/valkyrie/generator/jvm/imagevector/util/Names.kt(line 31), whereJetbrainsPreviewis defined as a ClassName pointing toandroidx.compose.desktop.ui.tooling.preview.PreviewUpdate the ClassName definition and test resources to use the new androidx.compose.ui.tooling.preview.Preview path.
Likely an incorrect or invalid review comment.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/PixelGrid.kt (1)
15-15: LGTM! Import updated correctly.The Preview annotation import has been successfully migrated from the desktop-specific package to the standard UI tooling package.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/TextWithIcon.kt (1)
18-18: LGTM! Import updated correctly.The Preview annotation import has been successfully migrated from the desktop-specific package to the standard UI tooling package.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/editor/edit/ui/EditorSelectUi.kt (1)
5-5: LGTM! Import updated correctly.The Preview annotation import has been successfully migrated from the desktop-specific package to the standard UI tooling package.
tools/idea-plugin/build.gradle.kts (2)
22-25: LGTM! Exclusion prevents desktop preview conflicts.The global exclusion for the desktop-specific UI tooling preview artifact ensures that the project uses only the standard UI tooling preview, avoiding potential classpath conflicts.
82-83: Update target version reference: IntelliJ IDEA 2025.2, not 2025.3+The
compileOnlyscope is appropriate for Preview annotations. The plugin is configured for IntelliJ IDEA 2025.2 (verified in pluginVerification configuration), and this dependency works correctly with that target version.Likely an incorrect or invalid review comment.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/DropdownMenu.kt (1)
28-28: LGTM! Import updated correctly.The Preview annotation import has been successfully migrated from the desktop-specific package to the standard UI tooling package.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/DragAndDropBox.kt (1)
27-27: LGTM! Preview import successfully migrated.The import change from desktop-specific to standard UI tooling preview aligns with the PR objective to support IntelliJ IDEA 2025.3+ preview functionality.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/FocusableTextField.kt (1)
48-48: LGTM! Preview import successfully migrated.The import change from desktop-specific to standard UI tooling preview aligns with the PR objective to support IntelliJ IDEA 2025.3+ preview functionality.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (59)
gradle/libs.versions.tomltools/gradle-plugin/build.gradle.ktstools/idea-plugin/build.gradle.ktstools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/action/dialog/RequiredIconPackModeDialog.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/common/picker/UniversalPicker.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/DragAndDropBox.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/DropdownMenu.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/FocusableTextField.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/InfoItem.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/InputField.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/PixelGrid.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/ScrollableTabRow.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/TextWithIcon.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/TooltipButton.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/TopAppBar.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/components/previewer/ImageVectorPreviewPanel.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/components/previewer/PreviewParsingError.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/components/previewer/TopActions.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/picker/GenericPickerScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/previewbg/PreviewBackground.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/editor/EditorSelectScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/editor/edit/EditScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/editor/edit/ui/EditorSelectUi.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/intro/IntroScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/IconPackConversionScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/DragAndDropOverlay.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/batch/BatchProcessingStateUi.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/batch/ui/IconPreviewBox.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/batch/ui/ImportIssues.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/picker/IconPackPickerStateUi.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/creation/common/packedit/ui/PackEditUi.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/existingpack/ExistingPackScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/existingpack/ui/foundation/ChooseExistingPackFile.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/existingpack/ui/foundation/ExistingPackEditor.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/newpack/NewPackScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/newpack/ui/foundation/ChoosePackDirectory.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/newpack/ui/foundation/NewPackCreation.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/imagevectortoxml/conversion/ImageVectorToXmlScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/imagevectortoxml/conversion/ui/action/EditActionContent.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/simple/conversion/SimpleConversionScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/simple/conversion/ui/action/EditActionContent.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/simple/conversion/ui/action/PreviewActionContent.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/AboutSettingsScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/GeneralSettingsScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/GeneratorSettingsScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/IndentSizeSection.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/OutputFormatSection.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/PreviewAnnotationSection.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/ui/SelectableCard.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/ui/SwitchOption.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/preview/ImageVectorPreviewSettingsScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/preview/PreviewBgSection.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/WebImportSelectorScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/common/ui/CategoriesDropdown.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/common/ui/SearchInputField.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/common/ui/SidePanel.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/material/ui/FontCustomization.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/material/ui/FontFamilyDropdown.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/material/ui/MaterialTopActions.kt
✅ Files skipped from review due to trivial changes (1)
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/batch/ui/IconPreviewBox.kt
🚧 Files skipped from review as they are similar to previous changes (40)
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/picker/GenericPickerScreen.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/newpack/NewPackScreen.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/DragAndDropBox.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/InputField.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/OutputFormatSection.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/batch/ui/ImportIssues.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/IndentSizeSection.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/newpack/ui/foundation/NewPackCreation.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/ui/SwitchOption.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/creation/common/packedit/ui/PackEditUi.kt
- tools/gradle-plugin/build.gradle.kts
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/imagevectortoxml/conversion/ImageVectorToXmlScreen.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/components/previewer/ImageVectorPreviewPanel.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/TooltipButton.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/simple/conversion/SimpleConversionScreen.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/newpack/ui/foundation/ChoosePackDirectory.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/ScrollableTabRow.kt
- tools/idea-plugin/build.gradle.kts
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/FocusableTextField.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/InfoItem.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/DragAndDropOverlay.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/material/ui/FontFamilyDropdown.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/PreviewAnnotationSection.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/existingpack/ui/foundation/ExistingPackEditor.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/batch/BatchProcessingStateUi.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/imagevectortoxml/conversion/ui/action/EditActionContent.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/GeneralSettingsScreen.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/common/picker/UniversalPicker.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/components/previewer/PreviewParsingError.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/editor/edit/ui/EditorSelectUi.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/ui/SelectableCard.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/AboutSettingsScreen.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/simple/conversion/ui/action/EditActionContent.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/preview/PreviewBgSection.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/action/dialog/RequiredIconPackModeDialog.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/preview/ImageVectorPreviewSettingsScreen.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/existingpack/ui/foundation/ChooseExistingPackFile.kt
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/TopAppBar.kt
- gradle/libs.versions.toml
- tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/components/previewer/TopActions.kt
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-12-07T20:07:49.753Z
Learnt from: egorikftp
Repo: ComposeGears/Valkyrie PR: 750
File: tools/gradle-plugin/src/main/kotlin/io/github/composegears/valkyrie/gradle/internal/task/GenerateImageVectorsTask.kt:71-85
Timestamp: 2025-12-07T20:07:49.753Z
Learning: In the Valkyrie Gradle plugin (Kotlin), the `useFlatPackage` flag in `IconPackExtension` is only applicable when nested packs are configured. For single icon packs (without nested packs), the flag is intentionally not propagated to `ImageVectorGeneratorConfig` as there is no package hierarchy to flatten.
Applied to files:
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/IconPackConversionScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/existingpack/ExistingPackScreen.kttools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/picker/IconPackPickerStateUi.kt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build (ubuntu-latest)
🔇 Additional comments (17)
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/editor/edit/EditScreen.kt (1)
15-15: LGTM! Import refactoring correctly applied.The import change from the desktop-specific preview to the standard androidx preview annotation is correct and aligns with fixing IntelliJ IDEA 2025.3+ preview support as stated in the PR objectives.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/simple/conversion/ui/action/PreviewActionContent.kt (1)
9-9: LGTM! Import updated to use standard androidx Preview annotation.The change from
androidx.compose.desktop.ui.tooling.preview.Previewtoandroidx.compose.ui.tooling.preview.Previewaligns with the PR objective to fix preview support for IntelliJ IDEA 2025.3+. The annotation usage remains syntactically identical and this change is part of a systematic refactoring across the codebase with appropriate build configuration updates.tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/settings/tabs/generator/GeneratorSettingsScreen.kt (1)
12-12: Import migration is correct; dependency version concern already tracked.The import change from
androidx.compose.desktop.ui.tooling.preview.Previewtoandroidx.compose.ui.tooling.preview.Previewcorrectly aligns with the PR objective to support IntelliJ IDEA 2025.3+. The annotation is used appropriately at line 99.Note: A previous review already identified the Compose library version mismatch (ui 1.8.2 vs ui-tooling-preview 1.10.0) which should be resolved to ensure compatibility.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/intro/IntroScreen.kt (1)
18-18: LGTM! Import refactoring aligns with PR objectives.The switch from desktop-specific to standard androidx preview annotation correctly addresses IntelliJ IDEA 2025.3+ compatibility. The
@Previewusage remains unchanged, ensuring no functional impact.tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/DropdownMenu.kt (1)
28-28: LGTM! Import updated to use standard androidx Preview annotation.The migration from
androidx.compose.desktop.ui.tooling.preview.Previewtoandroidx.compose.ui.tooling.preview.Previewis correct and aligns with the PR objectives to fix preview support for IntelliJ IDEA 2025.3+. The@Previewannotation usage at line 141 remains valid with this import change.tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/material/ui/MaterialTopActions.kt (1)
5-5: LGTM!The import update is consistent with the preview annotation refactoring across the project. The change correctly migrates from the desktop-specific to the standard UI tooling preview annotation.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/existingpack/ExistingPackScreen.kt (1)
15-15: LGTM! Import refactored consistently.The Preview import change is consistent with the broader migration across the codebase. The @Preview annotation at line 109 remains unaffected.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/PixelGrid.kt (1)
15-15: LGTM! Import updated correctly.The Preview import change aligns with the project-wide refactoring. The @Preview usage at line 60 remains unchanged.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/ui/picker/IconPackPickerStateUi.kt (1)
5-5: LGTM! Import migration complete.The Preview import has been successfully updated to use androidx tooling, consistent with the rest of the PR. The @Preview annotation at line 36 continues to function as expected.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/conversion/IconPackConversionScreen.kt (1)
37-37: LGTM! Preview import correctly migrated to androidx.compose.ui.tooling.preview.Preview.The import change aligns with Compose Multiplatform 1.10.0 best practices, which deprecated the desktop-specific
androidx.compose.desktop.ui.tooling.preview.Previewin favor of the unifiedandroidx.compose.ui.tooling.preview.Previewannotation. This supports IntelliJ IDEA 2025.3+ and works across common/shared code. The @Preview annotations remain functionally identical.tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/previewbg/PreviewBackground.kt (1)
11-11: LGTM! The import change is consistent with the project-wide refactoring to use UI tooling Preview instead of desktop tooling Preview. Version 1.10.0 is the latest stable release and appropriate for production use.tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/editor/EditorSelectScreen.kt (1)
19-19: LGTM! Preview annotation compatibility with IntelliJ IDEA 2025.3+ confirmed.The import change from
androidx.compose.desktop.ui.tooling.preview.Previewtoandroidx.compose.ui.tooling.preview.Previewis correct and recommended. The desktop-specific annotation is deprecated; the unifiedandroidx.compose.ui.tooling.preview.Previewis the standard cross-platform Preview API and is fully supported in IntelliJ IDEA 2025.3+ with appropriate plugins (Kotlin/Compose tooling or Kotlin Multiplatform plugin). The @Preview annotation usage remains unchanged and correct.tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/foundation/TextWithIcon.kt (1)
18-18: Import change is correct; version compatibility confirmed.The migration to
androidx.compose.ui.tooling.preview.Previewon line 18 is correct. Version 1.10.0 is compatible with IntelliJ IDEA 2025.3, provided the IDE has matching Kotlin and Compose plugins installed/updated.Note: Legacy import references remain in test resource files and code generation metadata (unrelated to this file's change).
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/common/ui/SidePanel.kt (1)
19-19: LGTM! Preview import updated correctly.The import change from desktop tooling to standard androidx preview is correct and aligns with the PR's objective to support IntelliJ IDEA 2025.3+.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/common/ui/SearchInputField.kt (1)
32-32: LGTM! Preview import updated correctly.The import change is consistent with the project-wide migration to androidx preview tooling.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/common/ui/CategoriesDropdown.kt (1)
5-5: LGTM! Preview import updated correctly.The import change is correct and maintains consistency with the broader refactoring effort.
tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/WebImportSelectorScreen.kt (1)
13-13: LGTM! Preview import updated correctly.The import change is correct and consistent with the PR's migration to androidx preview tooling. Verification confirms all 64 files in the desktop preview module have been migrated to androidx.compose.ui.tooling.preview, with no remaining desktop imports. Library version 1.10.0 is current and has no known security issues.
1 participant
Fix preview for IntelliJ IDEA 2025.3+