You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The pull request relocates the ValkyrieIcons public API surface from the compose:icons module to a new sdk:compose:icons module. All icon-related classes, extension properties, and accessor functions are removed from compose/icons/api/ and added to sdk/compose/icons/api/. The source files are moved with updated package declarations from io.github.composegears.valkyrie.compose.icons.* to io.github.composegears.valkyrie.sdk.compose.icons.*. The Gradle module configuration is updated accordingly, and all consumer imports throughout the codebase are updated to use the new SDK package paths.
The title 'Move :compose:icons into sdk' directly and clearly describes the primary change: relocating the compose:icons module into the sdk namespace.
Description check
✅ Passed
The description references issue #592 and is related to the changeset, which involves moving the compose:icons module into the sdk namespace.
Docstring Coverage
✅ Passed
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
📝 Generate docstrings
🧪 Generate unit tests (beta)
Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch task/move-compose-icons
No actionable comments were generated in the recent review. 🎉
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.