Skip to content

Move :compose:icons into sdk#845

Merged
egorikftp merged 1 commit intomainfrom
task/move-compose-icons
Feb 10, 2026
Merged

Move :compose:icons into sdk#845
egorikftp merged 1 commit intomainfrom
task/move-compose-icons

Conversation

@egorikftp
Copy link
Copy Markdown
Member

@egorikftp egorikftp commented Feb 10, 2026

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 10, 2026

Walkthrough

The pull request relocates the ValkyrieIcons public API surface from the compose:icons module to a new sdk:compose:icons module. All icon-related classes, extension properties, and accessor functions are removed from compose/icons/api/ and added to sdk/compose/icons/api/. The source files are moved with updated package declarations from io.github.composegears.valkyrie.compose.icons.* to io.github.composegears.valkyrie.sdk.compose.icons.*. The Gradle module configuration is updated accordingly, and all consumer imports throughout the codebase are updated to use the new SDK package paths.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Move :compose:icons into sdk' directly and clearly describes the primary change: relocating the compose:icons module into the sdk namespace.
Description check ✅ Passed The description references issue #592 and is related to the changeset, which involves moving the compose:icons module into the sdk namespace.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch task/move-compose-icons

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@egorikftp egorikftp merged commit ba3d4a3 into main Feb 10, 2026
5 checks passed
@egorikftp egorikftp deleted the task/move-compose-icons branch February 10, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant