Discontinue support for Material icon pack#851
Conversation
c81b821 to
99ff0a5
Compare
WalkthroughThis pull request removes support for the Material icon pack from the Valkyrie IDE plugin. The changes include deletion of the ExpandedGroup composable component, removal of the 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/newpack/ui/viewmodel/NewPackInputHandler.kt`:
- Around line 19-25: The packageName InputState is created without setting
isValid, so pre-populated values from PackageExtractor.getFrom(...) leave
InputFieldState.packageName.isValid=false and the UI disables the Next button;
update the initialization in NewPackInputHandler (where InputFieldState is
constructed) to set packageName.isValid based on your package-name validation
(i.e., mark true when PackageExtractor.getFrom(...) yields a non-empty, valid
package) or alternatively call the validation routine in BasicInputHandler
during initialization to invoke onValidationChange for the pre-filled
packageName so the field state and UI are reconciled before the first UI
observation.
99ff0a5 to
63cf85f
Compare
Uh oh!
There was an error while loading. Please reload this page.