Skip to content

Discontinue support for Material icon pack#851

Merged
egorikftp merged 1 commit intomainfrom
feature/Discontinue-support-for-the-Material-icon-pack
Feb 12, 2026
Merged

Discontinue support for Material icon pack#851
egorikftp merged 1 commit intomainfrom
feature/Discontinue-support-for-the-Material-icon-pack

Conversation

@egorikftp
Copy link
Copy Markdown
Member

@egorikftp egorikftp commented Feb 11, 2026


@egorikftp egorikftp force-pushed the feature/Discontinue-support-for-the-Material-icon-pack branch from c81b821 to 99ff0a5 Compare February 11, 2026 19:34
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 11, 2026

Walkthrough

This pull request removes support for the Material icon pack from the Valkyrie IDE plugin. The changes include deletion of the ExpandedGroup composable component, removal of the useMaterialPack state property from ValkyrieState and related settings classes, elimination of the UseMaterialPack action class, removal of Material pack UI options from the new pack creation screen, simplification of the icon pack input state construction, and deletion of associated localization strings. Additionally, the allowAddNestedPack parameter is removed from the NestedPacks composable function and related state classes.

🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Discontinue support for Material icon pack' directly and clearly describes the main objective of the pull request.
Description check ✅ Passed The PR description follows the template with the linked issue referenced (#850) and changelog checkboxes appropriately marked.
Linked Issues check ✅ Passed The pull request successfully implements issue #850 by removing Material icon pack support throughout the codebase.
Out of Scope Changes check ✅ Passed All changes are directly related to removing Material icon pack support, with no out-of-scope modifications detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/Discontinue-support-for-the-Material-icon-pack

No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In
`@tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/mode/iconpack/newpack/ui/viewmodel/NewPackInputHandler.kt`:
- Around line 19-25: The packageName InputState is created without setting
isValid, so pre-populated values from PackageExtractor.getFrom(...) leave
InputFieldState.packageName.isValid=false and the UI disables the Next button;
update the initialization in NewPackInputHandler (where InputFieldState is
constructed) to set packageName.isValid based on your package-name validation
(i.e., mark true when PackageExtractor.getFrom(...) yields a non-empty, valid
package) or alternatively call the validation routine in BasicInputHandler
during initialization to invoke onValidationChange for the pre-filled
packageName so the field state and UI are reconciled before the first UI
observation.

@egorikftp egorikftp force-pushed the feature/Discontinue-support-for-the-Material-icon-pack branch from 99ff0a5 to 63cf85f Compare February 11, 2026 19:44
@egorikftp egorikftp merged commit 597ba36 into main Feb 12, 2026
3 checks passed
@egorikftp egorikftp deleted the feature/Discontinue-support-for-the-Material-icon-pack branch February 12, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[IntelliJ] Discontinue support for the Material icon pack [rollback]

1 participant