You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PR extends the ImageVector PSI parser to support parsing standalone path() calls within material icon definitions alongside materialPath() calls. A new internal parsePathNode() extension function is introduced in PathParser to centralize path node construction logic. The material import check is updated from androidx.compose.material.icons.materialFilled to androidx.compose.material.icons.materialIcon. MaterialImageVectorPsiParser is modified to collect and parse regular path calls, while RegularImageVectorPsiParser refactors to use the new shared parsing function. Test resources and expected values are added to verify material icons containing path calls.
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.
Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check
⚠️ Warning
The PR description consists only of a changelog checklist with no substantive explanation of what was fixed or why.
Add a detailed description explaining the bug being fixed, the root cause, the solution implemented, and which changelog files were actually updated. Reference the PR objectives for context.
✅ Passed checks (2 passed)
Check name
Status
Explanation
Title check
✅ Passed
The title accurately describes the main change: fixing PSI parsing to support materialIcon blocks with regular path calls, which is the core objective across all modified files.
Merge Conflict Detection
✅ Passed
✅ No merge conflicts detected when merging into main
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
📝 Generate docstrings
🧪 Generate unit tests (beta)
Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch bug/fix_psi-parsing-for-materialicon-with-regular-path
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.