Skip to content

Fix PSI parsing for materialIcon with regular path calls#856

Merged
egorikftp merged 1 commit intomainfrom
bug/fix_psi-parsing-for-materialicon-with-regular-path
Feb 13, 2026
Merged

Fix PSI parsing for materialIcon with regular path calls#856
egorikftp merged 1 commit intomainfrom
bug/fix_psi-parsing-for-materialicon-with-regular-path

Conversation

@egorikftp
Copy link
Copy Markdown
Member

@egorikftp egorikftp commented Feb 12, 2026


@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 12, 2026

Walkthrough

The PR extends the ImageVector PSI parser to support parsing standalone path() calls within material icon definitions alongside materialPath() calls. A new internal parsePathNode() extension function is introduced in PathParser to centralize path node construction logic. The material import check is updated from androidx.compose.material.icons.materialFilled to androidx.compose.material.icons.materialIcon. MaterialImageVectorPsiParser is modified to collect and parse regular path calls, while RegularImageVectorPsiParser refactors to use the new shared parsing function. Test resources and expected values are added to verify material icons containing path calls.

🚥 Pre-merge checks | ✅ 2 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The PR description consists only of a changelog checklist with no substantive explanation of what was fixed or why. Add a detailed description explaining the bug being fixed, the root cause, the solution implemented, and which changelog files were actually updated. Reference the PR objectives for context.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing PSI parsing to support materialIcon blocks with regular path calls, which is the core objective across all modified files.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bug/fix_psi-parsing-for-materialicon-with-regular-path

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@egorikftp egorikftp merged commit 920e224 into main Feb 13, 2026
5 checks passed
@egorikftp egorikftp deleted the bug/fix_psi-parsing-for-materialicon-with-regular-path branch February 13, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant