Skip to content

[Web Import] Move standard components into common package#917

Merged
egorikftp merged 1 commit intomainfrom
task/move-shared-logic
Feb 28, 2026
Merged

[Web Import] Move standard components into common package#917
egorikftp merged 1 commit intomainfrom
task/move-shared-logic

Conversation

@egorikftp
Copy link
Copy Markdown
Member

@egorikftp egorikftp commented Feb 28, 2026

just clean up
image


📝 Changelog

If this PR introduces user-facing changes, please update the relevant Unreleased section in changelogs:

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 28, 2026

Walkthrough

This pull request reorganizes the package structure within the standard web import feature module. Multiple files are relocated from io.github.composegears.valkyrie.ui.screen.webimport.standard to io.github.composegears.valkyrie.ui.screen.webimport.standard.common across domain, model, and ui packages. Affected files include StandardIconViewModel, StandardImportScreenUI, CategoryInferrer, DisplayNameFormatter, StandardIconProvider, SvgSizeCustomizer, and various model classes (IconStyle, InferredCategory, SizeSettings, StandardIcon, StandardIconConfig). Import paths in bootstrap, boxicons, lucide, and remix import screens and their corresponding use cases are updated to reference the relocated files. No functional logic or public API signatures are modified.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning PR description includes only the changelog template checkbox without any actual description of the changes, objectives, or context for the refactoring. Add a detailed description explaining the purpose of moving standard components into the common package, what components were moved, and why this refactoring improves the codebase structure.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The PR title '[Web Import] Move standard components into common package' clearly and specifically summarizes the main change: relocating standard web import components into a common package structure.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch task/move-shared-logic

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@egorikftp egorikftp merged commit ff3367e into main Feb 28, 2026
5 checks passed
@egorikftp egorikftp deleted the task/move-shared-logic branch February 28, 2026 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants