Skip to content

Conversation

@Devanshusisodiya
Copy link

@Devanshusisodiya Devanshusisodiya commented Feb 12, 2025

Important

Add deeplake and azure to core_requirements in setup.py.

  • Dependencies:
    • Added deeplake and azure to core_requirements in setup.py.

This description was created by Ellipsis for 9d5d206. It will automatically update as commits are pushed.

@vercel
Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
composio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 2:27pm

@entelligence-ai-pr-reviews
Copy link

LGTM 👍

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped PR review on a642979 because no changed files had a supported extension. If you think this was in error, please contact us and we'll fix it right away.

@shreysingla11
Copy link
Collaborator

CI Fix Review

This PR currently contains no changes but is titled "fix: ci fix". Based on the repository analysis, there appears to be a critical issue in the CI configuration that needs addressing:

  1. The e2e job in .github/workflows/common.yml references a make ci command in the dockerfiles directory, but the Makefile is missing. This likely causes CI failures.

Recommendations:

  1. Add the missing Makefile in the dockerfiles directory with the necessary ci target for Docker image building
  2. OR Update the e2e job to use direct Docker commands instead of relying on make

Please add the necessary changes to fix the CI issues. An empty commit won't resolve the underlying problems.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on 206a604 in 1 minute and 6 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. python/setup.py:46
  • Draft comment:
    Consider adding version constraints for the 'deeplake' dependency for consistency and to prevent potential future breakage.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_V8yxt65cipGkQjaH


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

"jsonref>=1.1.0",
"inflection>=0.5.1",
"semver>=2.13.0",
"deeplake",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider pinning 'deeplake' with version constraints for consistency.

Suggested change
"deeplake",
"deeplake>=1.0.0,<2.0.0",

"inflection>=0.5.1",
"semver>=2.13.0",
"deeplake",
"azure",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The azure package dependency is too broad and may pull in unnecessary packages. Specify the exact Azure package(s) needed (e.g. azure-storage-blob, azure-core, etc).

📝 Committable Code Suggestion

‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
"azure",
"azure-storage-blob", "azure-core",

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on 9d5d206 in 2 minutes and 47 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. python/setup.py:47
  • Draft comment:
    Consider adding version constraints to the 'azure' dependency.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_JuHU13eAzwFWhAtN


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

"inflection>=0.5.1",
"semver>=2.13.0",
"deeplake",
"azure",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider specifying a version constraint for 'azure' (e.g., 'azure>=x.y.z') to avoid potential compatibility issues.

@angrybayblade
Copy link
Contributor

marking stale

@CryogenicPlanet CryogenicPlanet deleted the fix/ci branch October 28, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants